This repository has been archived by the owner. It is now read-only.

IE <= 8 throwing error: Object doesn't support this action #400

Closed
GCheung55 opened this Issue Mar 7, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@GCheung55
Contributor

GCheung55 commented Mar 7, 2014

IE <= 8 has been throwing an error with buster-test and buster-static browser tests.

Object doesn't support this action

It's referring to delete this.sinon; and the like.

@dwittner dwittner added the Bug label Mar 7, 2014

@dwittner dwittner self-assigned this Mar 7, 2014

@dwittner

This comment has been minimized.

Member

dwittner commented Mar 11, 2014

Unfortunately the delete statements are not the only problem in IE<=8, hence it will need a little bit more time to get it running.

@dwittner

This comment has been minimized.

Member

dwittner commented Mar 12, 2014

Maybe it's not the final solution, but if you need a quick fix you can do the following:

  1. modify file browser-wiring.js, change the delete block at the end to the following:

    buster.sinon = sinon;
    try {
        delete this.define;
        delete this.when;
        delete this.async;
        delete this.platform;
        delete this._;
    } catch (e) {
        this['define'] = undefined;
        this['when'] = undefined;
        this['async'] = undefined;
        this['platform'] = undefined;
        this['_'] = undefined;
    }
  2. delete var buster = from the first line of the file amd-shim.js, so that the resulting line is:

    this.buster = this.buster || {};

For me the tests then run in IE7, IE8 and IE10. Nevertheless i will provide a proved fix asap.

@dwittner

This comment has been minimized.

Member

dwittner commented Mar 13, 2014

Fixed by 1a5f65031c.

@dwittner dwittner closed this Mar 13, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.