This repository has been archived by the owner. It is now read-only.

Non-existant files are allowed in the config file #78

Closed
augustl opened this Issue Feb 16, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@augustl
Member

augustl commented Feb 16, 2012

It should probably freak out and tell the user about the none-existing file.

@cjohansen

This comment has been minimized.

Member

cjohansen commented Feb 20, 2012

This is actually by design, because it allows you to provide globs that doesn't match anything. We can't tell if something is a path or a glob, and we pass a series of globs to the globber, and tracking whether or not a single pattern yielded 0 files is kinda non-trivial. Is this very important? Is it better to have it fail on e.g. src/**/*.js before you've added anything to src?

@augustl

This comment has been minimized.

Member

augustl commented Feb 21, 2012

A glob returns an empty array doesn't it? If it does, globbing will add zero entries, not one none-existing entry. Hence adding a none-existing entry could fail. Not sure if this is how globbing works though.

@augustl

This comment has been minimized.

Member

augustl commented Mar 10, 2012

Bump!

@cjohansen

This comment has been minimized.

Member

cjohansen commented Mar 10, 2012

Explanation: We do glob([pattern, pattern, pattern]) if that returns more than 0 files, it's hard to tell which pattern returned nothing. Guess I could give buster-glob a strict mode of sorts.

@cjohansen

This comment has been minimized.

@cjohansen cjohansen closed this Mar 15, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.