Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.4 based update for IME bugs #746

Closed
tnmt opened this issue Sep 30, 2020 · 4 comments
Closed

v0.12.4 based update for IME bugs #746

tnmt opened this issue Sep 30, 2020 · 4 comments

Comments

@tnmt
Copy link

tnmt commented Sep 30, 2020

Hi.

I made PR #745 but there is no appropriate branch to contribute.

Could you cherry-pick 8f05bcf to 0.12.4 and release in 0.12.5 ?

Thanks.

@ZeeJab
Copy link
Member

ZeeJab commented Oct 1, 2020

I prefer not to, but if it's a blocker we can consider it. What is your blocker to upgrading to 0.13.x?

@tnmt
Copy link
Author

tnmt commented Oct 1, 2020

Thank you for reply and sorry for insufficient information.

I use Ghost CMS https://github.com/TryGhost/Ghost and Ghost uses own TryGhost/mobiledoc-kit based on bustle/mobiledoc-kit.
Unfortunately TryGhost/mobiledoc-kit is still based on 0.12.x (you can see in release page). I surmise that TryGhost community have some difficulty with catching up to original 0.13.x changes. There are some old dist path specifications in many Ghost code.

I once planed to patch TryGhost/mobiledoc-kit, but I guess that TryGhost/mobiledoc-kit is not only project which use 0.12.x bustle/mobiledoc-kit, so I suggest this Issue.

This bug (fix in #738) is hard problem for me (and maybe other IME users like #548 TryGhost#11 TryGhost/Ghost#11460) and I want to fix older 0.12.x version also.

If 0.12.5 will be release, I will discuss with Ghost community for taking in this change.
Or should I limit to patch each project which use old mobiledoc-kit ?

@ZeeJab
Copy link
Member

ZeeJab commented Oct 6, 2020

Released v0.12.5 with the IME fix backported. Let me know if you run into any trouble.

@ZeeJab ZeeJab closed this as completed Oct 6, 2020
@tnmt
Copy link
Author

tnmt commented Oct 7, 2020

Thank you for release v0.12.5 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants