Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic reconnect creates multiple terminal divs #333

Closed
acaos opened this issue Apr 6, 2021 · 8 comments
Closed

Automatic reconnect creates multiple terminal divs #333

acaos opened this issue Apr 6, 2021 · 8 comments

Comments

@acaos
Copy link

acaos commented Apr 6, 2021

Describe the bug
When wetty disconnects and automatically reconnects, a second terminal <div> element is created. This results in the scrollbar appearing very odd.

To Reproduce

  1. Create a Docker container running wetty.
  2. Start a wetty session in the browser (I use Firefox, but this happens in Chrome and Chromium as well).
  3. Restart the container. Note that wetty shows the Reconnect button briefly.
  4. Wetty automatically reconnects.
    • A second <div class="terminal xterm"> is created.
    • Content from the first session is duplicated and pushed over to the scrollbar area.

Expected behavior

  • The scrollbar area is not polluted with content from the previous session.
  • No second div is created.

Screenshots
image
image

Desktop:

  • OS: Windows 10 Professional
  • Browser: Firefox (latest)
  • Version: Wetty 2.0.3

Additional Information:

  • Using the browser's reload button works correctly. No additional <div> is created in this case.
@github-actions
Copy link

Stale issue message

@acaos
Copy link
Author

acaos commented Aug 25, 2021

This is still an issue for me in the most recent 2.1.1 release of wetty.

@github-actions
Copy link

Stale issue message

@acaos
Copy link
Author

acaos commented Oct 25, 2021

This is still an issue for me.

@gdschut
Copy link

gdschut commented Nov 8, 2021

I have the same issue :(

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Stale issue message

@acaos
Copy link
Author

acaos commented Jan 9, 2022

This is still an issue for me as of 2.1.2.

@butlerx
Copy link
Owner

butlerx commented Jan 29, 2022

Sorry for the stale notices that plugins a lot more aggressive then i intended.

I''ll have fix in the next release 2.1.3

@butlerx butlerx closed this as completed Jan 29, 2022
@butlerx butlerx mentioned this issue Aug 2, 2022
@butlerx butlerx mentioned this issue Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants