Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape special chars in username: - . \ @ #406

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

revarcline
Copy link
Contributor

Regarding #387 - for my intended use of wetty we are all using usernames with periods in them. This PR allows the following characters for usernames: -, ., \, and @ I presume there may be a security reason that these are not allowed, so if this PR is not accepted, would one with an --insecure-characters flag possibly work?

@paulierco
Copy link

I can confirm that this works as expected. Thanks for sharing this.

@butlerx
Copy link
Owner

butlerx commented Jul 31, 2022

Please fix the lining errors and once the test pass I can merge.
Please also add tests to the spec file for the username styles you require

@revarcline
Copy link
Contributor Author

done, thanks for the feedback (fwiw i skipped the no-useless-escape rule on the regex line)

@butlerx butlerx merged commit 1e4f173 into butlerx:main Aug 2, 2022
@butlerx butlerx mentioned this pull request Aug 2, 2022
@butlerx butlerx mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants