Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Sort by Title' is sorting lowercase apart from uppercase #476

Closed
carlmrichter opened this issue Dec 26, 2017 · 5 comments
Closed

'Sort by Title' is sorting lowercase apart from uppercase #476

carlmrichter opened this issue Dec 26, 2017 · 5 comments

Comments

@carlmrichter
Copy link

@carlmrichter carlmrichter commented Dec 26, 2017

When sorting the entries in a group the sorting algorithm differentiates between lowercase and uppercase entries. Maybe it is just me, or the german habit of capital letters, but that is pretty annoying.
If you want a alphabettically sorted list, you have to (re)name the entries either just lowercase letters or just uppercase letters.

Maybe just give the user the option to choose between ignoring capital letters or not?

In my opinion, this could easily be fixed by transforming all strings to lowercase before sorting.

@sallar

This comment has been minimized.

Copy link
Member

@sallar sallar commented Dec 26, 2017

Thanks @carlmrichter, I should have ignored casing before sorting. I will fix that.

@alireza-ahmadi

This comment has been minimized.

Copy link
Contributor

@alireza-ahmadi alireza-ahmadi commented Jan 12, 2018

@sallar I like to send a Pull Request for this, does this issue been resolved?

@sallar

This comment has been minimized.

Copy link
Member

@sallar sallar commented Jan 12, 2018

@alireza-ahmadi it's available. Feel free to take it :)

@alireza-ahmadi

This comment has been minimized.

Copy link
Contributor

@alireza-ahmadi alireza-ahmadi commented Jan 12, 2018

@sallar Great, should lowercasing items only get applied to entries or it should get applied to the groups as well?

@sallar

This comment has been minimized.

Copy link
Member

@sallar sallar commented Jan 12, 2018

@alireza-ahmadi there is a generic sort function on buttercup, it can be done there so its applied everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.