Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Retrieving an icon from some urls freezes the app #520
OS: Windows 10
The whole app will spike CPU usage, freeze, and I have to kill it a few seconds after I start navigating my imported database. The freeze is not attached to any specific action, the only requirement is to start navigating the imported database, and within a few seconds the app will freeze 100% of the time.
I suspected it being related to favicon retrieval and that some of the items has a url with a weird favicon that is freezing your app when it's trying to process it. After a lot of trial and error I've managed to isolate the app freezing to an item with this url:
Here is a test database that will always freeze the app a few seconds after clicking on
Please, make the icon retrieval so robust that this won't happen again no matter how unconventional the content behind the url.
Turns out that the icon from ello.co is only 3 bytes in length:
Using the library that we currently have to detect image types, I wonder if it's dying on such an item?
EDIT: Actually, something more weird is going on. Iconographer is breaking and freezing in tests requesting from that domain.. I'll debug further.