New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving an icon from some urls freezes the app #520

Closed
darsain opened this Issue Feb 16, 2018 · 6 comments

Comments

3 participants
@darsain

darsain commented Feb 16, 2018

OS: Windows 10
Version: 1.1.0

The whole app will spike CPU usage, freeze, and I have to kill it a few seconds after I start navigating my imported database. The freeze is not attached to any specific action, the only requirement is to start navigating the imported database, and within a few seconds the app will freeze 100% of the time.

I suspected it being related to favicon retrieval and that some of the items has a url with a weird favicon that is freezing your app when it's trying to process it. After a lot of trial and error I've managed to isolate the app freezing to an item with this url:

https://ello.co

Here is a test database that will always freeze the app a few seconds after clicking on Freezing item folder:

test.zip

Master password: a

Please, make the icon retrieval so robust that this won't happen again no matter how unconventional the content behind the url.

@sallar

This comment has been minimized.

Show comment
Hide comment
@sallar

sallar Feb 16, 2018

Member

@darsain yup it froze:

image

I'll investigate.

Member

sallar commented Feb 16, 2018

@darsain yup it froze:

image

I'll investigate.

@perry-mitchell

This comment has been minimized.

Show comment
Hide comment
@perry-mitchell

perry-mitchell Feb 18, 2018

Member

Thanks @darsain - Nice effort getting this together!

I can also confirm that it freezes, but it seems that it's just the renderer/UI part that dies. All of the menus are still responsive. I'll test in our icon downloader.

Member

perry-mitchell commented Feb 18, 2018

Thanks @darsain - Nice effort getting this together!

I can also confirm that it freezes, but it seems that it's just the renderer/UI part that dies. All of the menus are still responsive. I'll test in our icon downloader.

@perry-mitchell

This comment has been minimized.

Show comment
Hide comment
@perry-mitchell

perry-mitchell Feb 18, 2018

Member

Turns out that the icon from ello.co is only 3 bytes in length:

01 02 03

Or AQID in base64..

Using the library that we currently have to detect image types, I wonder if it's dying on such an item?

EDIT: Actually, something more weird is going on. Iconographer is breaking and freezing in tests requesting from that domain.. I'll debug further.

Member

perry-mitchell commented Feb 18, 2018

Turns out that the icon from ello.co is only 3 bytes in length:

01 02 03

Or AQID in base64..

Using the library that we currently have to detect image types, I wonder if it's dying on such an item?

EDIT: Actually, something more weird is going on. Iconographer is breaking and freezing in tests requesting from that domain.. I'll debug further.

@perry-mitchell

This comment has been minimized.

Show comment
Hide comment
@perry-mitchell

perry-mitchell Feb 18, 2018

Member

I can confirm that this works for me in master, after updating iconographer:

image

Member

perry-mitchell commented Feb 18, 2018

I can confirm that this works for me in master, after updating iconographer:

image

@sallar sallar added this to the v1.2.2 milestone Feb 18, 2018

@sallar

This comment has been minimized.

Show comment
Hide comment
@perry-mitchell

This comment has been minimized.

Show comment
Hide comment
@perry-mitchell

perry-mitchell Feb 18, 2018

Member

Thanks @sallar !

I can confirm that this is fixed:

image

Member

perry-mitchell commented Feb 18, 2018

Thanks @sallar !

I can confirm that this is fixed:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment