New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce single instance mode #544

Closed
darsain opened this Issue Feb 22, 2018 · 6 comments

Comments

2 participants
@darsain

darsain commented Feb 22, 2018

Buttercup doesn't have a single instance mode enabled. This allows multiple buttercup instances to run, possibly fighting over database access and creating conflicts in settings storage.

Practical case when this might happen: you have buttercup open, and you want to add another .bcup database. You double click on it and instead of it being added to the current instance (or activated when it's already in the list, related issue #543) you get a new buttercup window. And since both instances share the same settings storage, there will definitely be conflicts and confusion.

@sallar

This comment has been minimized.

Show comment
Hide comment
@sallar

sallar Feb 22, 2018

Member

@darsain Can I send you a windows executable of my change, so you can test this?

Member

sallar commented Feb 22, 2018

@darsain Can I send you a windows executable of my change, so you can test this?

@sallar

This comment has been minimized.

Show comment
Hide comment

@sallar sallar modified the milestones: v1.3.0, next-release Feb 22, 2018

@darsain

This comment has been minimized.

Show comment
Hide comment
@darsain

darsain Feb 22, 2018

@sallar Yes, there is no 2nd window being launched, instead the 1st one gets focused, which is correct, but ... nothing happens. If I double-click a .bcup file to open it, something should happen. When nothing does it feels like a bug.

The database should get added to the list, and when it already is in the list it should just get activated.

darsain commented Feb 22, 2018

@sallar Yes, there is no 2nd window being launched, instead the 1st one gets focused, which is correct, but ... nothing happens. If I double-click a .bcup file to open it, something should happen. When nothing does it feels like a bug.

The database should get added to the list, and when it already is in the list it should just get activated.

@sallar

This comment has been minimized.

Show comment
Hide comment
@sallar

sallar Feb 22, 2018

Member

and when it already is in the list it should just get activated.

@darsain well this one is a separate issue that you mentioned before. so that's for another time. but right now the archive should get added to the list like a normal double-click. I'll check what's wrong.

Member

sallar commented Feb 22, 2018

and when it already is in the list it should just get activated.

@darsain well this one is a separate issue that you mentioned before. so that's for another time. but right now the archive should get added to the list like a normal double-click. I'll check what's wrong.

@sallar

This comment has been minimized.

Show comment
Hide comment
@sallar
Member

sallar commented Feb 22, 2018

@darsain

This comment has been minimized.

Show comment
Hide comment
@darsain

darsain Feb 22, 2018

Yeah it opens the file now.

darsain commented Feb 22, 2018

Yeah it opens the file now.

@sallar sallar closed this in #546 Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment