Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Interface updates #744

Merged
merged 26 commits into from Feb 10, 2019

Conversation

@sallar
Copy link
Member

commented Jan 30, 2019

  • Remove Sass
  • Update dependencies
  • Remove flow
  • Redesign Password dialog
  • Improve icon security

Fixes #519
Fixes #62
Fixes #531

@sallar sallar changed the title WIP: January Chores User Interface updates Feb 10, 2019
@sallar sallar force-pushed the deps-update branch from b654236 to e7797f7 Feb 10, 2019
@sallar sallar requested review from ph1p and perry-mitchell Feb 10, 2019
@sallar sallar added this to the next-release milestone Feb 10, 2019
Copy link
Member

left a comment

Looks good! Just a couple of things..

</ListItem>
)
)}
{entries.map(({ entry, sourceID, groupID, path }, index) => (

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

index is redeclared below.. maybe they could be uniquely named resultIndex and groupIndex perhaps?

/>
</Button>
</ButtonRow>
<React.Fragment>

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

Any particular reason this isn't destructured? 😊

This comment has been minimized.

Copy link
@sallar

sallar Feb 10, 2019

Author Member

@perry-mitchell LAZINESS 😂

:not(input):not(textarea)::before {
-webkit-user-select: none;
user-select: none;
/*cursor: default;*/

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

Can this be removed?

--groups-bg: #292C33;
--groups-bg-mac: rgba(0,0,0,.2);
--entries-bg: #31353D;
/*--entries-bg-mac: rgba(49, 53, 61, 0.4);*/

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

Could this be removed?

onSelect={this.handleSelect}
onExpand={this.handleExpand}
onDrop={this.handleDrop}
<React.Fragment>

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

Destructuring?

loading={this.state.installing}
disabled={this.state.installing}
>
<React.Fragment>

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

Destructuring?

const { modalRequest } = this.state;

return (
<React.Fragment>

This comment has been minimized.

Copy link
@perry-mitchell

perry-mitchell Feb 10, 2019

Member

Destructuring?

@sallar

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2019

@perry-mitchell done mate. Now using the Fragment shorthand to void importing it (and react has official support for shorthand)

Copy link
Member

left a comment

Looks great!

@sallar sallar merged commit bf57402 into master Feb 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sallar sallar deleted the deps-update branch Feb 10, 2019
Copy link
Member

left a comment

Like it a lot! Good work! Looking forward to even more react hooks (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.