Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwarden importer #776

Merged
merged 3 commits into from Jul 11, 2019

Conversation

@loktacar
Copy link
Contributor

commented Jul 5, 2019

Added support for importing bitwarden json files. See issue buttercup/buttercup-importer#30 and pull request buttercup/buttercup-importer#38

loktacar added 2 commits Jul 5, 2019
lint-staged had to be updated to 7.0.5 to fix 'lint-staged requires at
least version 6 of Node' error. See
okonet/lint-staged#432
@sallar sallar added this to the next-release milestone Jul 6, 2019
@sallar

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

Thanks @loktacar! Can you please check the failing test as well?

@loktacar

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

Yes I'll check it out.

Use xvfb as a service and let it set the value of the DISPLAY env variable. See https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-services
@loktacar

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Hey @sallar, it seems that theres a difference in how xvfb is configured in travis-ci. I don't have any real experience with travis-ci but I changed it to how it's defined here: https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-services.

@sallar
sallar approved these changes Jul 11, 2019
@sallar sallar merged commit 7914dd0 into buttercup:master Jul 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loktacar loktacar deleted the loktacar:bitwarden-importer branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.