Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external_services.twitter.error #1708

Open
sentry-io bot opened this issue Jul 21, 2023 · 1 comment
Open

external_services.twitter.error #1708

sentry-io bot opened this issue Jul 21, 2023 · 1 comment
Labels
bug

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 21, 2023

Sentry Issue: APPLICATION-BACKEND-53N

external_services.twitter.error
@jmduke jmduke added the bug label Jul 21, 2023
@jmduke
Copy link
Member

jmduke commented Jul 21, 2023

There are a couple errors in this one, but the first one to tackle is this event:

https://buttondown-email.sentry.io/issues/4329599405/events/6f335c5e9c5a4b3b991876a659f7fd0d/?project=213773

What's happening

Buttondown is trying to fetch tweet details for a 'broadcast' tweet https://twitter.com/i/broadcasts/1OdKrzzAVnnKX?t=4s, which is a broadcast and not a tweet and therefore unaccessible via the API.

How to fix it

We should change the logic in markdown_rendering.extensions.twitter to be more selective; right now it just assumes everything with a prefix of https://twitter.com is a tweet, which is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Buttondown's public roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmduke @rasulkireev