Skip to content

Commit

Permalink
Adding more detail to the version info string
Browse files Browse the repository at this point in the history
This now contains a reference to the commit the build is based on and the branch it originates from. I'd have prefered to be able to embed a note about whether or not the build was based on a PR, but that doesn't seem trivial.

Fixes #255
  • Loading branch information
blackspherefollower authored and qdot committed Sep 4, 2017
1 parent cbc67e0 commit b3c5e4b
Show file tree
Hide file tree
Showing 19 changed files with 40 additions and 22 deletions.
Expand Up @@ -53,3 +53,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -34,3 +34,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -34,3 +34,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
2 changes: 1 addition & 1 deletion Buttplug.Apps.KiirooEmulatorGUI/Properties/AssemblyInfo.cs
Expand Up @@ -51,4 +51,4 @@
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
// Use informational version to store git hashes // Use informational version to store git hashes
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -52,4 +52,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
2 changes: 1 addition & 1 deletion Buttplug.Client.Test/Properties/AssemblyInfo.cs
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
2 changes: 1 addition & 1 deletion Buttplug.Client/Properties/AssemblyInfo.cs
Expand Up @@ -34,7 +34,7 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.1.1.0")] [assembly: AssemblyVersion("0.1.1.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]


// Let test project see internals // Let test project see internals
[assembly: InternalsVisibleTo("Buttplug.Client.Test")] [assembly: InternalsVisibleTo("Buttplug.Client.Test")]
Expand Down
23 changes: 19 additions & 4 deletions Buttplug.Components.Controls/ButtplugAboutControl.xaml.cs
Expand Up @@ -11,6 +11,7 @@ namespace Buttplug.Components.Controls
public partial class ButtplugAboutControl public partial class ButtplugAboutControl
{ {
private string _gitHash; private string _gitHash;
private string _buildType;
private uint _clickCounter; private uint _clickCounter;


public event EventHandler AboutImageClickedABunch; public event EventHandler AboutImageClickedABunch;
Expand All @@ -23,12 +24,26 @@ public ButtplugAboutControl()
public void InitializeVersion() public void InitializeVersion()
{ {
AboutVersionNumber.Text = Assembly.GetEntryAssembly().GetName().Version.ToString(); AboutVersionNumber.Text = Assembly.GetEntryAssembly().GetName().Version.ToString();
_gitHash = System.Diagnostics.FileVersionInfo.GetVersionInfo(Application.ResourceAssembly.Location) var longVer = System.Diagnostics.FileVersionInfo.GetVersionInfo(Application.ResourceAssembly.Location)
.ProductVersion; .ProductVersion;
if (_gitHash.Length > 0) if (longVer.Length > 0)
{ {
AboutVersionNumber.Text += $"-{_gitHash.Substring(0, 8)}"; AboutVersionNumber.Text = longVer;
AboutVersionNumber.MouseDown += GithubRequestNavigate; }

// AssemblyInformationalVersion("1.0.0.0-dev")
// version-type-hash

var pos = longVer.IndexOf('-');
if (pos > 0)
{
_buildType = longVer.Substring(pos);
pos = _buildType.IndexOf('-');
if (pos > 0)
{
_gitHash = _buildType.Substring(pos);
AboutVersionNumber.MouseDown += GithubRequestNavigate;
}
} }
} }


Expand Down
2 changes: 1 addition & 1 deletion Buttplug.Components.Controls/Properties/AssemblyInfo.cs
Expand Up @@ -52,4 +52,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
2 changes: 1 addition & 1 deletion Buttplug.Core/Properties/AssemblyInfo.cs
Expand Up @@ -34,7 +34,7 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.1.1.0")] [assembly: AssemblyVersion("0.1.1.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]


// Let test project see internals // Let test project see internals
[assembly: InternalsVisibleTo("Buttplug.Client.Test")] [assembly: InternalsVisibleTo("Buttplug.Client.Test")]
Expand Down
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
2 changes: 1 addition & 1 deletion Buttplug.Server.Test/Properties/AssemblyInfo.cs
Expand Up @@ -33,4 +33,4 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")] [assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]
2 changes: 1 addition & 1 deletion Buttplug.Server/Properties/AssemblyInfo.cs
Expand Up @@ -34,7 +34,7 @@
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("0.1.1.0")] [assembly: AssemblyVersion("0.1.1.0")]
[assembly: AssemblyFileVersion("1.0.0.0")] [assembly: AssemblyFileVersion("1.0.0.0")]
[assembly: AssemblyInformationalVersion("1.0.0.0")] [assembly: AssemblyInformationalVersion("1.0.0.0-dev")]


// Let test project see internals // Let test project see internals
[assembly: InternalsVisibleTo("Buttplug.Client.Test")] [assembly: InternalsVisibleTo("Buttplug.Client.Test")]
Expand Down
8 changes: 4 additions & 4 deletions appveyor.yml
Expand Up @@ -25,13 +25,13 @@ install:
function gitVersion() { function gitVersion() {
$env:newhash=git rev-parse HEAD $env:newhash=git rev-parse HEAD
$env:shorthash=git rev-parse --short HEAD $env:shorthash=git rev-parse --short HEAD
If ($env:appveyor_repo_tag -eq $TRUE) { If ($env:APPVEYOR_REPO_TAG -eq $TRUE) {
$env:newVersion=$env:appveyor_repo_tag_name $env:newVersion=$env:APPVEYOR_REPO_TAG_NAME
$env:appveyor_info_version=$env:appveyor_repo_tag_name $env:appveyor_info_version="$env:APPVEYOR_REPO_TAG_NAME-release-$env:APPVEYOR_REPO_COMMIT"
} Else { } Else {
$gitVersion=git describe --tags --abbrev=0 $env:APPVEYOR_REPO_BRANCH $gitVersion=git describe --tags --abbrev=0 $env:APPVEYOR_REPO_BRANCH
$env:newVersion="$gitVersion.$env:APPVEYOR_BUILD_NUMBER" $env:newVersion="$gitVersion.$env:APPVEYOR_BUILD_NUMBER"
$env:appveyor_info_version="$env:newVersion-alpha" $env:appveyor_info_version="$env:newVersion-$env:APPVEYOR_REPO_BRANCH-$env:APPVEYOR_REPO_COMMIT"
} }
$env:appveyor_build_version="$env:newVersion" $env:appveyor_build_version="$env:newVersion"
appveyor UpdateBuild -Version "$env:newVersion" appveyor UpdateBuild -Version "$env:newVersion"
Expand Down

0 comments on commit b3c5e4b

Please sign in to comment.