Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetGattServicesForUuidAsync() failed to find services #635

Merged
merged 1 commit into from Jul 28, 2019

Conversation

blackspherefollower
Copy link
Contributor

This was an issue discovered with the MagicMotion Vini
which wasn't showing up due to not getting a service
returned. The service was present and useable when
GetServicesAsync() was called instead.

Additioanlly:

  • more logging is now emitted from the UWP BLE manager
    when this sort of error occures
  • only one attempt to create a connection to a specific
    device happens at once now (previously multiple threads
    could be launched to create a connection for a single
    device).

This was an issue discovered with the MagicMotion Vini
which wasn't showing up due to not getting a service
returned. The service was present and useable when
GetServicesAsync() was called instead.

Additioanlly:
- more logging is now emitted from the UWP BLE manager
  when this sort of error occures
- only one attempt to create a connection to a specific
  device happens at once now (previously multiple threads
  could be launched to create a connection for a single
  device).
@blackspherefollower
Copy link
Contributor Author

The Youcups worked with this the first time I turned it on today, then resumed failing afterwards.

@qdot qdot merged commit bf90a31 into buttplugio:dev Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants