Red, artifacted images in dev build 2086 #10

Closed
inlikealion opened this Issue Jul 25, 2011 · 7 comments

Comments

Projects
None yet
4 participants
@inlikealion

On OS X 10.6.8, ST2 build 2086. Git cloned repo into ~/Library/Application Support/Sublime Text 2/Packages, then enabled via Global User Settings. This results in changed theme, but any area that is image dependent is a bright red, distorted area.

See: http://cl.ly/2R160d1F2d2N193A0B1o

@lunixbochs

This comment has been minimized.

Show comment
Hide comment
@lunixbochs

lunixbochs Jul 26, 2011

put it in Packages/User/, not Packages/.

the documentation maybe should be more clear to NOT put it in Packages, instead of just saying to put it in User

put it in Packages/User/, not Packages/.

the documentation maybe should be more clear to NOT put it in Packages, instead of just saying to put it in User

@guillermooo

This comment has been minimized.

Show comment
Hide comment
@guillermooo

guillermooo Jul 26, 2011

Btw, why can't it be made to work off Packages? Isn't that where it should belong along with the Default theme?

Btw, why can't it be made to work off Packages? Isn't that where it should belong along with the Default theme?

@buymeasoda

This comment has been minimized.

Show comment
Hide comment
@buymeasoda

buymeasoda Jul 26, 2011

Owner

Yeah, I was undecided myself about whether it should go in /Packages or /Packages/User.

When I began the theme development, before I had read a lot about the general Sublime Text 2 setup, I had put it in /Packages. That also seems to be where many people put it if they miss the information in the readme file.

There's no technical reason why it can't be in /Packages, it would just be a matter of changing the paths to the assets in the theme file.

In the end I decided to go with the /Packages/User folder because of information about the user folder at: http://sublimetext.info/docs/en/basic_concepts.html

It seemed like it was the spot Jon designed for this sort of stuff.

From the sublimetext.info site:

The User Package

Packages/User is a catch-all directory for custom plugins, snippets, macros, etc. Consider it your personal area in the > packages folder. Sublime Text 2 will never overwrite the contents of Packages/User during upgrades.

I might see if he can offer some feedback on where it should go by design, or does anyone know if themes are expected to be inside or outside the user folder?

Happy to move it there if that's deemed more appropriate.

Owner

buymeasoda commented Jul 26, 2011

Yeah, I was undecided myself about whether it should go in /Packages or /Packages/User.

When I began the theme development, before I had read a lot about the general Sublime Text 2 setup, I had put it in /Packages. That also seems to be where many people put it if they miss the information in the readme file.

There's no technical reason why it can't be in /Packages, it would just be a matter of changing the paths to the assets in the theme file.

In the end I decided to go with the /Packages/User folder because of information about the user folder at: http://sublimetext.info/docs/en/basic_concepts.html

It seemed like it was the spot Jon designed for this sort of stuff.

From the sublimetext.info site:

The User Package

Packages/User is a catch-all directory for custom plugins, snippets, macros, etc. Consider it your personal area in the > packages folder. Sublime Text 2 will never overwrite the contents of Packages/User during upgrades.

I might see if he can offer some feedback on where it should go by design, or does anyone know if themes are expected to be inside or outside the user folder?

Happy to move it there if that's deemed more appropriate.

@guillermooo

This comment has been minimized.

Show comment
Hide comment
@guillermooo

guillermooo Jul 26, 2011

It's worth noting that I'm the author of the docs at sublimetext.info ;) IMO, User should be reserved for stuff the user wants to put there. Your theme can be seen as a "third party" addon, so it feels Packages is the right spot for it. Also, it should become the default, and then it will go in Packages! :)

It's worth noting that I'm the author of the docs at sublimetext.info ;) IMO, User should be reserved for stuff the user wants to put there. Your theme can be seen as a "third party" addon, so it feels Packages is the right spot for it. Also, it should become the default, and then it will go in Packages! :)

@buymeasoda

This comment has been minimized.

Show comment
Hide comment
@buymeasoda

buymeasoda Jul 26, 2011

Owner

It's worth noting that I'm the author of the docs at sublimetext.info ;

Haha, awesome. Now that gives me a chance to thank you personally for all your hard work on putting together and maintaining the site, so cheers ;)

I'll have a look at moving it. The unfortunate side effect of moving it will be that anyone who's cloned the theme and does an update would get a broken theme with the images path changes.

As an aside, if the theme system used the theme file location as the starting location for relative asset referencing, rather than referencing explicitly from /Packages down, it would avoid the location problem and allow the theme to reside in either location. I wonder if that's something Jon would consider investigating.

For example, if assets paths could be (relative to the theme file):

"layer0.texture": "Soda Light/tabset-background.png"

Rather than relative to the packages folder (which will become busted with a move to /Packages):

"layer0.texture": "User/Theme - Soda/Soda Light/tabset-background.png"

That would allow people to put it anywhere that a theme can be parsed and loaded, and the assets would always be fine.

Owner

buymeasoda commented Jul 26, 2011

It's worth noting that I'm the author of the docs at sublimetext.info ;

Haha, awesome. Now that gives me a chance to thank you personally for all your hard work on putting together and maintaining the site, so cheers ;)

I'll have a look at moving it. The unfortunate side effect of moving it will be that anyone who's cloned the theme and does an update would get a broken theme with the images path changes.

As an aside, if the theme system used the theme file location as the starting location for relative asset referencing, rather than referencing explicitly from /Packages down, it would avoid the location problem and allow the theme to reside in either location. I wonder if that's something Jon would consider investigating.

For example, if assets paths could be (relative to the theme file):

"layer0.texture": "Soda Light/tabset-background.png"

Rather than relative to the packages folder (which will become busted with a move to /Packages):

"layer0.texture": "User/Theme - Soda/Soda Light/tabset-background.png"

That would allow people to put it anywhere that a theme can be parsed and loaded, and the assets would always be fine.

@guillermooo

This comment has been minimized.

Show comment
Hide comment
@guillermooo

guillermooo Jul 26, 2011

Haha, awesome. Now that gives me a chance to thank you personally for
all your hard work on putting together and maintaining the site, so cheers ;)

No problem! :)

As an aside, if the theme system used the theme file location as
the starting location for relative asset referencing, rather than
referencing explicitly from /Packages down

Considering that Themes don't include code, what you suggest sounds sensible. Theme "packages" perhaps should be self-contained and relocatable. Maybe it's worth asking in the forum. There might be some reason why this isn't the case now, but I fail to see it.

Haha, awesome. Now that gives me a chance to thank you personally for
all your hard work on putting together and maintaining the site, so cheers ;)

No problem! :)

As an aside, if the theme system used the theme file location as
the starting location for relative asset referencing, rather than
referencing explicitly from /Packages down

Considering that Themes don't include code, what you suggest sounds sensible. Theme "packages" perhaps should be self-contained and relocatable. Maybe it's worth asking in the forum. There might be some reason why this isn't the case now, but I fail to see it.

@buymeasoda

This comment has been minimized.

Show comment
Hide comment
@buymeasoda

buymeasoda Jul 27, 2011

Owner

PLEASE NOTE: Theme folder location has now been relocated from "Packages/User" to "Packages" in the latest update

The theme has now been updated to work when placed inside the Packages folder instead of inside Packages/User. If you have cloned the theme into the User folder, you will see a broken theme (with red backgrounds) on the next git pull. To correct this issue, move the Theme - Soda folder from inside User to inside Packages.

See GitHub: Theme location issue and Sublime Forum: Theme location discussion for more details.

Owner

buymeasoda commented Jul 27, 2011

PLEASE NOTE: Theme folder location has now been relocated from "Packages/User" to "Packages" in the latest update

The theme has now been updated to work when placed inside the Packages folder instead of inside Packages/User. If you have cloned the theme into the User folder, you will see a broken theme (with red backgrounds) on the next git pull. To correct this issue, move the Theme - Soda folder from inside User to inside Packages.

See GitHub: Theme location issue and Sublime Forum: Theme location discussion for more details.

@buymeasoda buymeasoda closed this Jul 28, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment