Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Red, artifacted images in dev build 2086 #10
On OS X 10.6.8, ST2 build 2086. Git cloned repo into ~/Library/Application Support/Sublime Text 2/Packages, then enabled via Global User Settings. This results in changed theme, but any area that is image dependent is a bright red, distorted area.
Yeah, I was undecided myself about whether it should go in /Packages or /Packages/User.
When I began the theme development, before I had read a lot about the general Sublime Text 2 setup, I had put it in /Packages. That also seems to be where many people put it if they miss the information in the readme file.
There's no technical reason why it can't be in /Packages, it would just be a matter of changing the paths to the assets in the theme file.
In the end I decided to go with the /Packages/User folder because of information about the user folder at: http://sublimetext.info/docs/en/basic_concepts.html
It seemed like it was the spot Jon designed for this sort of stuff.
From the sublimetext.info site:
I might see if he can offer some feedback on where it should go by design, or does anyone know if themes are expected to be inside or outside the user folder?
Happy to move it there if that's deemed more appropriate.
It's worth noting that I'm the author of the docs at sublimetext.info ;) IMO, User should be reserved for stuff the user wants to put there. Your theme can be seen as a "third party" addon, so it feels Packages is the right spot for it. Also, it should become the default, and then it will go in Packages! :)
Haha, awesome. Now that gives me a chance to thank you personally for all your hard work on putting together and maintaining the site, so cheers ;)
I'll have a look at moving it. The unfortunate side effect of moving it will be that anyone who's cloned the theme and does an update would get a broken theme with the images path changes.
As an aside, if the theme system used the theme file location as the starting location for relative asset referencing, rather than referencing explicitly from /Packages down, it would avoid the location problem and allow the theme to reside in either location. I wonder if that's something Jon would consider investigating.
For example, if assets paths could be (relative to the theme file):
Rather than relative to the packages folder (which will become busted with a move to /Packages):
That would allow people to put it anywhere that a theme can be parsed and loaded, and the assets would always be fine.
No problem! :)
Considering that Themes don't include code, what you suggest sounds sensible. Theme "packages" perhaps should be self-contained and relocatable. Maybe it's worth asking in the forum. There might be some reason why this isn't the case now, but I fail to see it.
This comment has been minimized.
This comment has been minimized.
PLEASE NOTE: Theme folder location has now been relocated from "Packages/User" to "Packages" in the latest update
The theme has now been updated to work when placed inside the Packages folder instead of inside Packages/User. If you have cloned the theme into the User folder, you will see a broken theme (with red backgrounds) on the next git pull. To correct this issue, move the Theme - Soda folder from inside User to inside Packages.