New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new sidebar icons #188

Open
billdami opened this Issue Aug 29, 2014 · 12 comments

Comments

Projects
None yet
8 participants
@billdami

billdami commented Aug 29, 2014

ST3 Build 3065 introduces sidebar icons for folders and files, however it looks like Soda Dark is not fully compatible with this change as only folders show the new icons, not files:

screen shot 2014-08-29 at 9 29 50 am

Also, imo the way that the folder icons were implemented, displaying both the caret AND a folder icon next to it, is a bit ugly and wastes space. Is there any way soda theme could modify this to only show one or the other?

@createproblem

This comment has been minimized.

createproblem commented Aug 29, 2014

👍

@kachar

This comment has been minimized.

kachar commented Aug 29, 2014

👍
Actually there are two files to be added to the archive with the correct names. The new build requires icons/folder.png and icons/folder_open.png in the theme folder(archive).

@billdami

This comment has been minimized.

billdami commented Aug 29, 2014

Just noticed in issue #174 @buymeasoda does partially address this issue, basically ST currently does not let you specify different file icon paths within a single package, so he just left out the file icons completely for now. However, I did find a snippet to customize the theme which removes the empty space where the file icons should be (and also removes the new folder icons as well):

{
    "class": "icon_file_type",
    "content_margin": [0,0]
},
{
    "class": "icon_folder",
    "content_margin": [0,0]
},
{
     "class": "icon_folder_loading",
     "content_margin": [0,0]
}

I wonder if maybe at least the icon_file_type customization should be added to the Soda themes, until proper file type icon support is added.

@adrianorsouza

This comment has been minimized.

adrianorsouza commented Aug 29, 2014

The support sidebar icons for ST3 3065 it's more readable IMO Soda Theme could use this icons as default instead.

screen-shot-2014-08-29-at-17 41 07

@billdami

This comment has been minimized.

billdami commented Aug 29, 2014

@adrianorsouza Those would work for the Soda Light theme, but as you can tell from my screenshot above, you can barely see the folder icon against the dark background.

@adrianorsouza

This comment has been minimized.

adrianorsouza commented Aug 30, 2014

@billdami Yep I see, I did not realise that sorry, anyway what I did to get this working was to follow this comment download the icons, make them a better look for Dark theme and place them within the Theme - Soda folder, now it looks better like this:

screen-shot-2014-08-29-at-21 28 23

If you wish I pushed these icons to my fork adrianorsouza@5430e6a

@billdami

This comment has been minimized.

billdami commented Sep 2, 2014

@adrianorsouza Those icons work quite nicely, thanks! :-)

@nicklangridge

This comment has been minimized.

nicklangridge commented Sep 3, 2014

Also, imo the way that the folder icons were implemented, displaying both the caret AND a folder icon next to it, is a bit ugly and wastes space.

+1

@JTallis

This comment has been minimized.

JTallis commented Sep 13, 2014

@adrianorsouza those are very nice and I had a look at your fork. Soda Dark 3.sublime-theme was using the light icons instead of dark. Also, the sidebar file icons used the light icons too.

@adrianorsouza

This comment has been minimized.

adrianorsouza commented Sep 16, 2014

@JTallis because the sidebar icons feature of recent ST3 build only looks for a folder named icons there is no way that I know to use separated folders for having both Dark and Light sidebar icons, that was my workaround because I use the Light theme I had to place Light icons within the icons folder, if you intend to use Dark theme icons you need to rename icons_dark to icons.

@Stanzilla

This comment has been minimized.

Stanzilla commented May 10, 2015

You guys can try this theme, it is basicly soda dark with support for the native file icons in ST3 https://github.com/Miw0/sodareloaded-theme

@nicklangridge

This comment has been minimized.

nicklangridge commented May 11, 2015

@Stanzilla, thanks this looks good

@wunc wunc referenced this issue May 15, 2015

Closed

Icons AND Arrows? #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment