Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 3127 breaks theme #213

Open
antstorm opened this issue Apr 12, 2017 · 7 comments
Open

Build 3127 breaks theme #213

antstorm opened this issue Apr 12, 2017 · 7 comments

Comments

@antstorm
Copy link

antstorm commented Apr 12, 2017

Hey guys,

Just installed today's new release (build 3127) and looks like Soda theme has some issues.

Tabs look like the default ones:
screenshot 2017-04-12 09 40 41

Side bar won't show anything:
screenshot 2017-04-12 09 42 04

Command palette looks a bit off:
screenshot 2017-04-12 09 42 31

My bet is API incompatibility… but I'm no expert in this.

Would really appreciate if someone could have a look?

Soda has been my favourite theme for many years now and I haven't seen anything out there that can compete with it.

P.S. No errors appear in console
P.P.S Running on OS X

@sdemura
Copy link

sdemura commented Apr 12, 2017

Build 3128 on OS X has a working sidebar, but the tabs default to "classic" now, with no way to change them back it seems.

@mmacomber0
Copy link

I too was bothered by the default tabs coming back on dev build 3127 (through 3129)
Looking at Will's comment on the Dev Build 3127 discussion ( https://forum.sublimetext.com/t/dev-build-3127/27213/133 ), it looks like the texture for the tab wasn't getting set properly, but he'll have a fix for it in the next dev build.
Fingers crossed!

@zertosh
Copy link

zertosh commented Apr 19, 2017

Actually seems like Sublime is not assuming false for settings that it doesn't recognize. If you add this to your Preferences.sublime-settings, it looks ok again:

	"soda_retina_fix": false,
	"soda_classic_tabs": false,

@antwan
Copy link

antwan commented Apr 20, 2017

Anyone having an issue with tabs not scrolling ?

@Kronuz
Copy link

Kronuz commented Apr 20, 2017

tabset_control needs to be like this now for tabs scrolling to work:

    {
        "class": "tabset_control",
        "settings": ["mouse_wheel_switches_tabs", "!enable_tab_scrolling"],
        "mouse_wheel_switch": true
    },

@benpbolton
Copy link

Confirming that @Kronuz ' edit works (eg. from Soda Light 3.sublime-theme):

screen shot 2017-04-20 at 9 45 19 am

@antwan
Copy link

antwan commented Apr 20, 2017

Great fix thanks, that should be added to the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants