Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (React 15) #38

Closed
edtoken opened this issue Dec 13, 2017 · 2 comments
Closed

Update dependencies (React 15) #38

edtoken opened this issue Dec 13, 2017 · 2 comments

Comments

@edtoken
Copy link
Contributor

edtoken commented Dec 13, 2017

Hello.
I would like to update the dependencies and make small fixes with this (so far this update is only for React 15)
In the next few days I will make a pool request (everything is ready, it is necessary to check)
Thanks!

2017-12-13 19 21 38
2017-12-13 19 21 51

@bvaughn
Copy link
Owner

bvaughn commented Dec 18, 2017

Not sure I understand the motivation behind this. Could you explain?

For example, your screenshot shows updating prop-types from ^15.5.0 to ^15.6.0, but this isn't actually necessary. If you install this project now, NPM will pull in the latest 15.x release (which would be 15.6.0). No update necessary to install that newer version. However, if you raise the minimum version from ^15.5.0 to ^15.6.0 then anyone who might happen to have 15.5 installed would get an incompatible warning.

As I mentioned on the other issue (#39), I think that all that's required here is to update the peerDependencies block to also support React 16, eg: "react": "^0.14.0 || ^15.0.0 || ^16.0.0".

@bvaughn
Copy link
Owner

bvaughn commented Dec 18, 2017

I don't think there's anything to do here. Please correct me if I'm wrong, but for now I'm going to close this issue.

@bvaughn bvaughn closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants