Skip to content

Commit

Permalink
Fix grading for "done" button problems by changing
Browse files Browse the repository at this point in the history
(choose-mc-answer ...) -> (done ...) to match change in Help/Commands.cl
Bug #1747.
  • Loading branch information
bvds committed May 29, 2010
1 parent 0b10b9b commit ab225f7
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions Testcode/Tests.cl
Expand Up @@ -610,18 +610,13 @@
;;; answers. For non-quantitative problem parts, the workbench uses two
;;; sorts of controls instead of quantitative answer boxes:
;;; 1. "I'm Done" check boxes for qualitative parts like fbd drawing
;;; 2. Multiple choice question buttons.
;;; The existing lookup-mc-answer API was overloaded to handle both cases,
;;; treating the check box as a degenerate case of a multiple choice
;;; question. (Probably would be better to handle differently.)
;;; That explains why code below refers to I'm Done check boxes by the
;;; misleading label of "MC-answers". (Should change at some point.) True
;;; multiple choice answers are referred to as "multiple-choice-answers".
;;; 2. Multiple choice question buttons, either radio buttons
;;; or checkboxes with done button.
;;;
;;; Student entries for answer submissions carry propositions of the
;;; following forms:
;;; quantitative answer boxes: (Answer ...)
;;; done check boxes: (lookup-mc-answer ...)
;;; done check boxes: (done ...)
;;; multiple choice q's: (choose-answer ...)

;;; following predicates classify problem sought expressions:
Expand Down Expand Up @@ -709,7 +704,7 @@
(length
(remove-if-not
#'(lambda (E) (and (equalp (studententry-state E) +correct+)
(equalp (car (studententry-prop E)) 'lookup-mc-Answer)))
(equalp (car (studententry-prop E)) 'done)))
*Studententries*)))

(add-runtime-test
Expand Down

0 comments on commit ab225f7

Please sign in to comment.