Skip to content
This repository has been archived by the owner on Jul 25, 2020. It is now read-only.

+(OGVInputStream *)inputStreamWithURL:(NSURL *)URL is not available from Swift #217

Closed
olSolo opened this issue Aug 31, 2018 · 4 comments
Closed

Comments

@olSolo
Copy link

olSolo commented Aug 31, 2018

Therefore, I don't see any way to create a proper OGVInputStream

@bvibber
Copy link
Owner

bvibber commented Sep 1, 2018

I haven't tested interop with Swift yet so will have to do some testing. From my recollection of the message name translation rules it should be something like OGVInputStream.inputStream(URL: foo) ... ? But it might not be bridging correctly to begin with...

@olSolo
Copy link
Author

olSolo commented Sep 3, 2018

When translating to Swift, it cuts class name also, so it should look like OGVInputStream.(with: fooURL), which I guess is not valid.
I added two proxy method + (OGVInputStream *)createWithURL
and + (OGVInputStream *)createWithData
You can check my pull request #218

@bvibber
Copy link
Owner

bvibber commented Sep 5, 2018

Awesome -- I'll try to take a look at the pull req shortly. Thanks!

@olSolo
Copy link
Author

olSolo commented Sep 5, 2018

I don't really like this my solution, but I have no idea how to fix it nicely and keep version compatibility

@bvibber bvibber closed this as completed Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants