Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect VC++ Redist shipped with BWAPI 4.2.0 #724

Closed
adakitesystems opened this issue Jul 2, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@adakitesystems
Copy link

commented Jul 2, 2017

Both the manual BWAPI_420.7z and auto BWAPI_420_Setup.exe install packages are shipped with VC++ Redist 2013 where VC++ Redist 2015 is required.

@edran

This comment has been minimized.

Copy link

commented Aug 6, 2017

VC++ Redist 2015 can be downloaded here: https://www.microsoft.com/en-us/download/details.aspx?id=48145 - Choose the x86 version.

@chriscoxe

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2017

BWAPI 4.2.0 was built with the "v141" toolset using Visual Studio 2017, not 2015, so I think the VC++ Redist 2017 should be used, not 2015. I only needed to install the 2017 redist to make Chaoslauncher inject successfully on a vanilla Windows 7 SP1 VirtualBox VM.

@chriscoxe

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2017

Note that if you are using a 64-bit OS, the 2017 redist should be the x86 variant. The x64 variant can also be installed at the same time but the x86 variant is the one that is needed by BWAPI (the x64 variant is not needed by BWAPI). At the time of writing (11 Aug 2017), the latest x86 redist for 2017 is shown in "Add/Remove Programs" as "Microsoft Visual C++ 2017 Redistributable (x86) - 14.10.25017".

Also note that if the 2015 x86 redist is already installed when you install the 2017 x86 redist, it replaces the 2015 x86 redist and the 2015 one is no longer shown in the list of installed software - the 2017 x86 redist is shown instead. If you have any 2013 or earlier redists installed, they aren't replaced - they are still shown in "Add/Remove Programs".

@adakitesystems

This comment has been minimized.

Copy link
Author

commented Sep 5, 2017

I receive the following error when trying to use a 4.2.0 BWAPI.dll on a fresh Win7 SP1 32-bit install: "The program can't start because MSVCP140.dll is missing from your computer. Try reinstalling the program to fix this problem." After installing VC++ Redist 2015, I no longer receive this message. I see now in the project solution files of BWAPI that the toolset is set to 141. In this case, I agree VC++ Redist 2017 should be used even though VC++ Redist 2015 seems to resolve the issue.

chriscoxe added a commit that referenced this issue Mar 6, 2019

#724 Incorrect VC++ Redist shipped with BWAPI 4.2.0
Updating to latest Microsoft Visual C++ Redistributable for Visual Studio 2017 (x86)
@chriscoxe

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

I've updated the redist to the latest version, in the "develop" branch, and checked that the resulting installer (from AppVeyor) installs the correct redist on Win7 SP1. 4.2.0 and 4.3.0 have already been released, so it will be in the next release that is a higher version number than 4.3.0. Microsoft seem to update VS2017 & the redist quite often these days, so as part of every release (including the next release), I suggest checking whether the compiler version on AppVeyor has changed since the last release, and if so, update to the latest (x86) "Microsoft Visual C++ Redistributable for Visual Studio 2017" redist from https://support.microsoft.com/en-au/help/2977003/the-latest-supported-visual-c-downloads. This will ensure that future releases (and bots built using it) will work on machines that don't have VS2017 installed. Otherwise theoretically, BWAI/bots might experience some strange behaviour due to compatibility problems.

@chriscoxe chriscoxe added the bug 🐞 label Mar 6, 2019

@chriscoxe chriscoxe closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.