Changed State.MemberAdd to set fields individually #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the check failed to a network timeout completely unrelated to the code changed. :( |
|
Confirmed, this fixed the issue I reported in #532 for me. (And, just FTR, I built it fine with 1.10.1.) |
iopred
reviewed
Apr 12, 2018
| @@ -299,7 +299,17 @@ func (s *State) MemberAdd(member *Member) error { | |||
| members[member.User.ID] = member | |||
| guild.Members = append(guild.Members, member) | |||
| } else { | |||
| *m = *member // Update the actual data, which will also update the member pointer in the slice | |||
There was a problem hiding this comment.
Could you implement this in the same way as we do in Guild, it will mean that we don't have to update 2 places whenever the Member struct changes, ie:
// We are about to replace `m` in the state with `member`, but first we need to
// make sure we preserve any fields that the `member` doesn't contain from `m`.
if member.JoinedAt == "" {
member.JoinedAt = m.JoinedAt
}
*m = *member
There was a problem hiding this comment.
That looks like a better solution; will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #532. Though it's not mentioned on the Discord docs, it seems
Member.JoinedAtisn't sent in member updates (it is sent in member chunks), which caused the value to be overwritten to an empty value after member updates. This pull request changesState.MemberAddto handle each field individually, similarly to other function in the State that have similar dilemmas, checking for an emptyJoinedAtfield.