Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Invalid setting for custom theme definition described in documentation #7

Closed
Sebastian-Habenicht opened this Issue Nov 27, 2013 · 3 comments

Comments

Projects
None yet
2 participants

Hi,

according to the documentation the property name for the theme to use with an entry point is themeId:

"themeId - The ID of the registered theme (optional) . Please see the theme configuration section in this guide."

However, in EntryPointConfigurationHelper, line 57, the defined theme id is read from a property theme:

String themeId = values.theme ?: null

Hence, the defined custom theme is ignored. EntryPointConfigurationHelper and the documentation (and the grails-rwt-example, which also uses themeId in its configuration) should refer to the same property. I used plugin version rwt:1.0.

Regards,
Sebastian

@ghost ghost assigned bwolff Nov 27, 2013

Owner

bwolff commented Nov 27, 2013

Hi Sebastian,

I'll have a look, thanks for reporting this.

Cheers,
Ben

Owner

bwolff commented Nov 27, 2013

Fixed this issue and released version 1.0.1 that contains the fix. Thanks a lot for reporting!

You can upgrade your BuildConfig.groovy:

compile ":rwt:1.0.1"

Cheers,
Ben

@bwolff bwolff closed this Nov 27, 2013

Hi Ben,

thanks, I confirm that the issue does not occur anymore with version 1.0.1.

Regards
Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment