Skip to content
Commits on Jan 3, 2012
  1. @aselekman

    Update and Optimize iOS SDK for XCode 4

    Summary:
    Made the following changes:
    - Removed obsolete compiler flags
    - Exposed Public Headers
    - Set the Installation Directory to $(BUILT_PRODUCTS_DIR)
    - Set public header path to “$(TARGET_NAME)”
    - Set “Skip Install” build setting to Yes
    - Updated project format to XCode 4
    
    Test Plan: Added project to XCode 4 workspace, tested FB Login + SSO
    
    Reviewers: yariv, jimbru, brent
    
    Reviewed By: yariv
    
    CC: lshepard, caabernathy, security-diffs@lists, selekman, yariv
    
    Differential Revision: https://phabricator.fb.com/D383376
    aselekman committed Dec 29, 2011
Commits on Dec 20, 2011
  1. Update README.mdown

    dpurdy committed Dec 20, 2011
  2. Update README.mdown

    dpurdy committed Dec 20, 2011
Commits on Dec 19, 2011
  1. Removed unnecessary inheritance

    Summary: Quick code cleaning - Facebook class doesn't need to inherit from
    FBRequestDelegate.
    
    Test Plan: Check if it compiles and login in / login out works.
    
    Reviewers: yariv
    
    Reviewed By: yariv
    
    CC: jgabbard, yariv
    
    Differential Revision: 380359
    Kamil Kraszewski committed with Kamil Kraszewski Dec 19, 2011
  2. Added session expired error handling.

    Summary: Whenever we call an API that returns a "session expired" error we
    should clear the session data (acessToken / expiring date) and notify user about
    it.
    
    Test Plan: Login to app, then log out using www, then try calling rest / graph
    method.
    
    Reviewers: yariv, jimbru, brent, toddkrabach, jonathan
    
    Reviewed By: yariv
    
    CC: lshepard, yariv, kamil, brent, jonathan, toddkrabach
    
    Differential Revision: 378197
    Kamil Kraszewski committed with Kamil Kraszewski Dec 16, 2011
Commits on Dec 15, 2011
  1. Handling parallel requests

    Summary: Current SDK doesn't support multiple requests at the same time. To
    change this I added a new container to the Facebook class that stores all the
    requests. Whenever the request finishes it's work (by loading the response or by
    returning an error) we remove it from the container. Since FBRequests are
    autorelased they will be deleted at the end of the event loop.
    
    Test Plan: Check if the app works + tried to call the GetMe API method twice.
    
    Reviewers: yariv, toddkrabach, jonathan
    
    Reviewed By: toddkrabach
    
    CC: yariv, toddkrabach, jonathan, jimbru, lshepard, jgabbard, kamil
    
    Differential Revision: 378930
    Kamil Kraszewski committed with Kamil Kraszewski Dec 14, 2011
Commits on Dec 14, 2011
  1. Merged sessionDelegates in the Hackbook sample.

    Summary: Current Hackbook example implements two FBSessionDelegates. Switching
    between them requires modifying the internals of Facebook class and is very
    confusing. The solution is to remove FBSessionDelegate implementation from
    APICallsViewController, and modify the code in a way that will work with only
    one sessionDelegate.
    
    Test Plan:
    Try the following (two times every plan :) ):
      - login, execute any method, logout
      - login, execute any method, uninstall app
      - login, cancel login, login, execute any method, logout
      - login, request additional perms, cancel, request additional perms, grant,
    logout
    
    Reviewers: yariv
    
    Reviewed By: yariv
    
    CC: jimbru, lshepard, kamil, yariv
    
    Differential Revision: 377641
    Kamil Kraszewski committed with Kamil Kraszewski Dec 13, 2011
Commits on Dec 8, 2011
  1. Code cleaning of Hackbook example

    Summary: Removed trailing spaces, unified function definitions etc.
    
    Test Plan: Check if this compiles
    
    Reviewers: yariv, brent
    
    Reviewed By: yariv
    
    CC: jimbru, yariv
    
    Differential Revision: 374136
    Kamil Kraszewski committed with Kamil Kraszewski Dec 7, 2011
Commits on Nov 23, 2011
  1. Fix semantic warnings in Hackbook iOS sample app

    Summary: Use UITableViewCellSelectionStyleNone instead of
    UITableViewCellEditingStyleNone for selectionStyle.
    
    Test Plan: On iOS simulator 5.0 test Hackbook iOS sample app, publish feed,
    graph api sections.
    
    Reviewers: brent
    
    Reviewed By: brent
    
    CC: lshepard, yariv, brent
    
    Differential Revision: 365804
    
    Revert Plan: OK
    Christine Abernathy committed Nov 21, 2011
Commits on Nov 19, 2011
  1. Update sample app to show how to handle dialog request results

    Summary:
    Part of the discussion of the abandoned diff https://phabricator.fb.com/D342789
    was that we should update the Hackbook iOS sample app to show developers how to
    process data passed back from the dialog. Changes were made to use
    dialogCompleteWithUrl: instead of
     dialogDidComplete: method. Other tweaks made to display a success message back
    to the user when an app request was sent. Also NSLog the post_id and request_ids
    information so developer can check these out.
    
    Changes still need to be made to the iOS SDK docs
    (https://developers.facebook.com/docs/reference/iossdk/FBDialogDelegate/) to let
    developers know how to handle the dialog data in the callback.
    
    Test Plan:
    1/ On iOS simulator 4.3 ran through the Publish Feed and Send Request flows.
    Checked it works and shows the proper user messages and debug messages (that
    developers could use in the future).
    2/ Tested on iPhone 5.0 and tested feed and app request dialog flows.
    
    Reviewers: brent
    
    Reviewed By: brent
    
    CC: lshepard, yariv, brent, caabernathy
    
    Differential Revision: 360490
    
    Revert Plan: OK
    
    Task ID: 697899
    Christine Abernathy committed with Christine Abernathy Nov 11, 2011
Commits on Nov 3, 2011
  1. Properly initialize FBDialog and Hackbook sample app data

    Summary:
    Related to pull requests
    facebook#405
    facebook#407
    
    Test Plan:
    1/ Tested Hackbook iOS app with iPhone 4 device with iOS 5, ran through various
    screens and tested dialog.
    2/ Tested Hackbook iOS app with iPad 2 device with iOS 4.3, ran through various
    screens and tested dialog.
    
    Reviewers: yariv, brent
    
    Reviewed By: yariv
    
    CC: lshepard, yariv
    
    Differential Revision: 355088
    
    Revert Plan: OK
    
    Task ID: 786690
    Christine Abernathy committed Nov 2, 2011
Commits on Nov 2, 2011
  1. @mattdipasquale

    Fix semantic warnings in iOS5 and Xcode 4.2

    Summary: Pulled from facebook#401
    
    Test Plan:
    1/ Ran on iPhone 4 device with iOS 5, Hackbook iOS app, launched feed dialog,
    rotate all orientations and check works as expected. Also rotated device before
    launching dialog and rotating dialog to see it performed well.
    2/ Ran experiment (1) with iPhone 4.3 simulator.
    3/ Ran experiment (1) with iPad 4.3 simulator.
    4/ Ran experiment (1) with iPad 5.0 simulator.
    
    Reviewers: yariv, brent
    
    Reviewed By: yariv
    
    CC: lshepard, yariv
    
    Differential Revision: 354600
    
    Revert Plan: OK
    
    Task ID: 673148
    mattdipasquale committed with Christine Abernathy Oct 13, 2011
Commits on Oct 13, 2011
  1. Removing old sample DemoApp.

    Christine Abernathy committed Oct 13, 2011
  2. Handle no friend case for publishing to friend's wall. Small memory l…

    …eak fix, need to release before making savedAPIResult nil first.
    Christine Abernathy committed Oct 13, 2011
  3. Update ignore file, delete files that should be ignored. Fix warning …

    …in UITableViewCell selectionStyle assignment
    Christine Abernathy committed Oct 13, 2011
Commits on Oct 10, 2011
  1. README tweaks

    Christine Abernathy committed Oct 10, 2011
  2. Merge branch 'master' of https://github.com/facebook/facebook-ios-sdk

    Christine Abernathy committed Oct 10, 2011
  3. @yariv

    Move the URL scheme suffix parameter from authorize: to init:

    Summary: Moving the url scheme suffix parameter from authorize: to init:, where
    it fits better, as it behaves in a similar way to appId.
    
    Test Plan: Modified the demo app to use the new method signatures. Verified SSO
    still worked with and without a url scheme suffix.
    
    Reviewers: lshepard, brent, caabernathy, teck
    
    Reviewed By: brent
    
    CC: brent
    
    Differential Revision: 335813
    yariv committed Sep 29, 2011
  4. Dialog UI improvements, updated README, new sample Hackbook app

    Christine Abernathy committed Oct 10, 2011
Commits on Sep 28, 2011
  1. @yariv

    rename localAppId to urlSchemeSuffix

    Summary: urlSchemeSuffix is more descriptive and easier to grok than
    localAppId.
    
    Warning: This changes breaks compatibility with the previous version of the SDK. Please update your code to use the latest method signature.
    
    Test Plan: compiled and ran the demo app with a urlSchemeSuffix configured
    
    Reviewers: brent, lshepard, teck
    
    Reviewed By: lshepard
    
    CC: brent, lshepard
    
    Differential Revision: 334704
    
    Task ID: 737701
    yariv committed Sep 27, 2011
Commits on Sep 23, 2011
  1. fix project file

    Michal Kijewsi committed Sep 23, 2011
Commits on Sep 13, 2011
  1. @yariv

    This reverts commit 74ae952.

    The original behavior is the correct behavior as it prevents random errors from popping up the inline login dialog.
    yariv committed Sep 13, 2011
Commits on Sep 10, 2011
  1. @lshepard

    Merge pull request #382 from FunkeeMonk/inline_fallback

    Fallback to inline authentication dialog if SSO login fails.
    lshepard committed Sep 9, 2011
Commits on Sep 9, 2011
  1. @FunkeeMonk

    Unless the server indicates a "service_disabled_use_browser" error, f…

    …allback to the inline authentication dialog in -[Facebook handleOpenURL:]
    FunkeeMonk committed Sep 10, 2011
Commits on Aug 29, 2011
  1. @lshepard

    Remove auth.expireSession call from SDK

    Summary: The expireSession call was put in as a precaution to make sure that
    apps sessions were really no longer good. However, this is unnecessary and it
    causes issues with apps that were expecting the session to remain usable even
    after the user logged out. So let's remove this call and leave it up to the app
    developer to expire the session if they want.
    
    Test Plan: Logged in and out of the demo app.
    
    Reviewed By: trvish
    lshepard committed Aug 29, 2011
Commits on Aug 26, 2011
  1. README changes only - Documentation update to match init session dele…

    …gate changes. Add notice on issue reporting.
    Christine Abernathy committed Aug 25, 2011
Commits on Aug 15, 2011
  1. @raghuc

    Refactor to init session delegate in Facebook.m constructor

    Summary: The change basically just sets the session delegate in the constructor so
    it's available when handleOpenUrl is called.
    
    Test Plan: Ran the DemoApp and ensured SSO still works.
    
    Reviewed By: toddkrabach
    
    Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy
    
    Differential Revision: 297414
    Task ID: 653835
    raghuc committed Aug 3, 2011
Commits on May 27, 2011
  1. @seshness

    Use the Graph API for the photo uploading example.

    Summary:
    Edited uploadPhoto to use requestWithGraphPath instead of the legacy REST api
    requestWithMethodName method. Also added the publish_stream permission, which
    is
    needed for uploading photos.
    
    Test Plan:
    Run the DemoApp and login. Click the upload button and verify that a photo was
    uploaded to the user's Facebook account (pending approval).
    
    Reviewed By: yariv
    Reviewers: yariv
    CC: yariv
    Differential Revision: 257551
    seshness committed May 25, 2011
Commits on May 17, 2011
  1. @yariv

    a couple of small cleanups

    yariv committed May 16, 2011
  2. @yariv

    small comment fix

    yariv committed May 16, 2011
  3. @yariv

    Add the 'localAppId' param to [Facebook authorize]

    Summary:
    This is the SDK diff to support the local_client_id URL parameter that we added
    to the FB app. I named it 'localAppId' to be consistent with the 'appId'
    parameter to the same function.
    
    Test Plan:
    bound the demo app to 'fb1234foo' and passed 'foo' as the localAppId value.
    verified the SDK used the 'fbauth2' url scheme to open the fb app and that the
    fb app successfully redirected back to the demo app.
    
    Reviewed By: brent
    Reviewers: lshepard, atishm, brent, oyamauchi, jimbru
    CC: brent
    Differential Revision: 211201
    yariv committed Feb 10, 2011
Commits on Apr 6, 2011
  1. @caabernathy
Commits on Jan 31, 2011
  1. Return FBRequest* from request: methods.

    The request: selectors in the Facebook class now return a pointer to the
    instantiated FBRequest object (rather than void). This makes it easier
    to know in the delegate callback which request the callback maps to.
    Jim Brusstar committed Jan 31, 2011
Commits on Dec 14, 2010
  1. @bgold

    fixing docs link

    bgold committed Dec 13, 2010
Commits on Dec 8, 2010
  1. Updates to README for platform dialogs.

    Jim Brusstar committed Dec 7, 2010
Something went wrong with that request. Please try again.