Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest commit breaks python3 compatibility #8

Closed
fj-sanchez opened this issue Feb 12, 2020 · 1 comment
Closed

Latest commit breaks python3 compatibility #8

fj-sanchez opened this issue Feb 12, 2020 · 1 comment

Comments

@fj-sanchez
Copy link

fj-sanchez commented Feb 12, 2020

In python3 the print syntax is different and requires parenthesis:

 Traceback (most recent call last):
   File "/usr/local/bin/mkdocs", line 8, in <module>
     sys.exit(cli())
   File "/usr/local/lib/python3.7/site-packages/click/core.py", line 764, in __call__
     return self.main(*args, **kwargs)
   File "/usr/local/lib/python3.7/site-packages/click/core.py", line 717, in main
     rv = self.invoke(ctx)
   File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
     return _process_result(sub_ctx.command.invoke(sub_ctx))
   File "/usr/local/lib/python3.7/site-packages/click/core.py", line 956, in invoke
     return ctx.invoke(self.callback, **ctx.params)
   File "/usr/local/lib/python3.7/site-packages/click/core.py", line 555, in invoke
     return callback(*args, **kwargs)
   File "/usr/local/lib/python3.7/site-packages/mkdocs/__main__.py", line 162, in build_command
     site_dir=site_dir
   File "/usr/local/lib/python3.7/site-packages/mkdocs/config/base.py", line 197, in load_config
     errors, warnings = cfg.validate()
   File "/usr/local/lib/python3.7/site-packages/mkdocs/config/base.py", line 107, in validate
     run_failed, run_warnings = self._validate()
   File "/usr/local/lib/python3.7/site-packages/mkdocs/config/base.py", line 62, in _validate
     self[key] = config_option.validate(value)
   File "/usr/local/lib/python3.7/site-packages/mkdocs/config/config_options.py", line 132, in validate
     return self.run_validation(value)
   File "/usr/local/lib/python3.7/site-packages/mkdocs/config/config_options.py", line 572, in run_validation
     plgins[item] = self.load_plugin(item, cfg)
   File "/usr/local/lib/python3.7/site-packages/mkdocs/config/config_options.py", line 580, in load_plugin
     Plugin = self.installed_plugins[name].load()
   File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2443, in load
     return self.resolve()
   File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2449, in resolve
     module = __import__(self.module_name, fromlist=['__name__'], level=0)
   File "/usr/local/lib/python3.7/site-packages/mkdocs_minify_plugin/plugin.py", line 33
     print "htmlmin option " + key + " not recognized"
                           ^
 SyntaxError: Missing parentheses in call to 'print'. Did you mean print("htmlmin option " + key + " not recognized")?
                           ^
@byrnereese
Copy link
Owner

Fixed in 0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants