Faster PNG striping #8
Conversation
| @@ -52,8 +52,6 @@ | |||
| png_metadata = ChunkyPNG::Image.from_file(png_path.to_s).metadata | |||
| expect(png_metadata).to be_empty | |||
|
|
|||
| # Metadata usually contains some timestamps, so sleeping is the best way to make sure they are all stripped | |||
| sleep 1 | |||
There was a problem hiding this comment.
If the metadata are properly stripped, how come this break the build?
There was a problem hiding this comment.
I still don't know. Theoretical, even before it was being striped correctly
but I think there is something in the data itself that is time dependent
and is not included in the metadata.
On ter, 13 de set de 2016 at 13:10 Jean Boussier notifications@github.com
wrote:
In spec/rails_spec.rb
#8 (comment):@@ -52,8 +52,6 @@
png_metadata = ChunkyPNG::Image.from_file(png_path.to_s).metadata
expect(png_metadata).to be_empty
# Metadata usually contains some timestamps, so sleeping is the best way to make sure they are all strippedsleep 1If the metadata are properly stripped, how come this break the build?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/byroot/sprockets-svg/pull/8/files/270cf5d2448c2db2046007e2004736a452cb6099#r78591837,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC66GuShiaa8o3mSTEPM6Xp-BgAKGpOks5qpsrqgaJpZM4J72xp
.
There was a problem hiding this comment.
If so, then it's a problem. Not just because of the flaky test suite, but also because sprockets does require consistent fingerprints.
There was a problem hiding this comment.
It should be fixed now that I removed the tIME chunk that store the last modified information http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html
rafaelfranca
force-pushed
the
fast-png-strip
branch
from
270cf5d
to
b241de3
Compare
I found that when the image is really big the ChunkyPNG gem is slow to encode/decode the PNG pixels. As we only want to strip the metadata we can work in the Datastream that doesn't transform the pixels. With my test image this method went from 10s to 0.01s.
rafaelfranca
force-pushed
the
fast-png-strip
branch
from
b241de3
to
255c817
Compare
|
Thanks. Feel free to merge on green, you have commit access IIRC. |
|
Oh. I don't think I'm part of the byroot core team yet 😄 |
|
Oh really? That can be arranged |
I found that when the image is really big the ChunkyPNG gem is slow to encode/decode the PNG pixels. As we only want to strip the metadata we can work in the Datastream that doesn't transform the pixels.
With my test image this method went from 10s to 0.01s.