Skip to content

Conversation

@vados-cosmonic
Copy link
Contributor

No description provided.

@vados-cosmonic
Copy link
Contributor Author

Hey @tschneidereit I fixed the config to make sure non-cc commits get in there, if we can get this in relatively quickly I'm happy to recreate that release (or you can click the button again 😄 really happy to see someone else using the automation!)

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and apologies for not catching the problematic commit message.

I wonder if we should add a commit message check so the release notes actually work okay?

@tschneidereit tschneidereit merged commit 03eb63b into bytecodealliance:main Sep 8, 2025
12 checks passed
@vados-cosmonic vados-cosmonic deleted the fix(ops)=add-catchall-for-cliff-toml branch September 8, 2025 11:39
@vados-cosmonic
Copy link
Contributor Author

Ah so it's not that the commit message was problematic, it was the absense of the thing you actually wanted to release! I was wondering why you might be excited to release only a testing change... Then realized that can't be the reason noticed Karthik's comment wasn't showing up!

I tested locally, and with this, we should get both commit messages to properly show up next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants