Skip to content

Conversation

@vados-cosmonic
Copy link
Contributor

@vados-cosmonic vados-cosmonic commented Oct 17, 2025

A few changes in here:

  • Use Node versions as matrix inputs
  • Use pinned setup-node (and update to v6)
  • Switch back to windows-latest
  • Remove tight time budget in test given unreliability of CI
  • Remove retries for tests (we shouldn't actually need this now -- it can be re-introduced for specific tests if we find a need)

@vados-cosmonic vados-cosmonic changed the title fix(ci): tests on windows runner fix(ci): miscellaneous improvements to CI and tests Oct 17, 2025
@vados-cosmonic
Copy link
Contributor Author

Hey @tschneidereit would you mind taking a look at this?

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, LGTM!

This commit allows retries for the bulitins test suite, in particular
`now-disabled` which seems to timeout sporadically.
@vados-cosmonic vados-cosmonic force-pushed the refactor(ci)=misc-improvements-to-ci-and-tests branch from 7e1cde0 to 29a7eba Compare October 24, 2025 13:30
@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Oct 24, 2025

Running into very very odd bug where only macos fails the recent duplicate import test -- think it might be due to a missing OS cached build for the splicer (there's one for windows and ubuntu, but not macos).

Hoping this isn't a regression and it's just using an old, splicer version that hasn't been updated for macos!

[EDIT] Yup, looks like there wasn't a recent splicer build -- will merge this after tests pass.

@vados-cosmonic vados-cosmonic merged commit 0adca22 into bytecodealliance:main Oct 24, 2025
19 checks passed
@vados-cosmonic vados-cosmonic deleted the refactor(ci)=misc-improvements-to-ci-and-tests branch October 24, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants