From 4e95679813c1430b3e53a304348ea2aa23d533f9 Mon Sep 17 00:00:00 2001 From: Gerard Smit Date: Wed, 27 Aug 2025 22:21:36 +0200 Subject: [PATCH 1/2] Fix tar on Windows --- src/WasmComponent.Sdk/WasmComponent.Sdk.csproj | 7 ++++++- src/WitBindgen/WitBindgen.csproj | 7 ++++++- ...BytecodeAlliance.Componentize.DotNet.WitBindgen.targets | 7 ++++++- test/WasmtimeCliFetcher/FetchWasmtime.targets | 6 +++++- 4 files changed, 23 insertions(+), 4 deletions(-) diff --git a/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj b/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj index a3d1c57..656dd40 100644 --- a/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj +++ b/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj @@ -29,6 +29,11 @@ false + + C:\Windows\System32\tar.exe + tar + + @@ -96,7 +101,7 @@ - + diff --git a/src/WitBindgen/WitBindgen.csproj b/src/WitBindgen/WitBindgen.csproj index e1dba4f..9984d18 100644 --- a/src/WitBindgen/WitBindgen.csproj +++ b/src/WitBindgen/WitBindgen.csproj @@ -33,6 +33,11 @@ false + + C:\Windows\System32\tar.exe + tar + + @@ -74,7 +79,7 @@ - + diff --git a/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets b/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets index 844cad2..3f55e7b 100644 --- a/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets +++ b/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets @@ -11,6 +11,11 @@ + + C:\Windows\System32\tar.exe + tar + + - + diff --git a/test/WasmtimeCliFetcher/FetchWasmtime.targets b/test/WasmtimeCliFetcher/FetchWasmtime.targets index 29ed2d9..c408532 100644 --- a/test/WasmtimeCliFetcher/FetchWasmtime.targets +++ b/test/WasmtimeCliFetcher/FetchWasmtime.targets @@ -17,12 +17,16 @@ https://github.com/bytecodealliance/wasmtime/releases/download/v$(WasmtimeVersion)/wasmtime-v$(WasmtimeVersion)-$(WasmtimeTarget)$(WasmtimeUrlExtension) + + C:\Windows\System32\tar.exe + tar + - + From 17b01e4c24e5f52357d38444ea4a95812e024e12 Mon Sep 17 00:00:00 2001 From: Gerard Smit Date: Wed, 27 Aug 2025 22:39:50 +0200 Subject: [PATCH 2/2] Use SystemRoot instead of hardcoded C-drive --- src/WasmComponent.Sdk/WasmComponent.Sdk.csproj | 2 +- src/WitBindgen/WitBindgen.csproj | 2 +- .../BytecodeAlliance.Componentize.DotNet.WitBindgen.targets | 2 +- test/WasmtimeCliFetcher/FetchWasmtime.targets | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj b/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj index 656dd40..6f4286f 100644 --- a/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj +++ b/src/WasmComponent.Sdk/WasmComponent.Sdk.csproj @@ -30,7 +30,7 @@ - C:\Windows\System32\tar.exe + $(SystemRoot)\System32\tar.exe tar diff --git a/src/WitBindgen/WitBindgen.csproj b/src/WitBindgen/WitBindgen.csproj index 9984d18..b04905b 100644 --- a/src/WitBindgen/WitBindgen.csproj +++ b/src/WitBindgen/WitBindgen.csproj @@ -34,7 +34,7 @@ - C:\Windows\System32\tar.exe + $(SystemRoot)\System32\tar.exe tar diff --git a/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets b/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets index 3f55e7b..9f732d3 100644 --- a/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets +++ b/src/WitBindgen/build/BytecodeAlliance.Componentize.DotNet.WitBindgen.targets @@ -12,7 +12,7 @@ - C:\Windows\System32\tar.exe + $(SystemRoot)\System32\tar.exe tar diff --git a/test/WasmtimeCliFetcher/FetchWasmtime.targets b/test/WasmtimeCliFetcher/FetchWasmtime.targets index c408532..eaf967d 100644 --- a/test/WasmtimeCliFetcher/FetchWasmtime.targets +++ b/test/WasmtimeCliFetcher/FetchWasmtime.targets @@ -18,7 +18,7 @@ - C:\Windows\System32\tar.exe + $(SystemRoot)\System32\tar.exe tar