Skip to content
This repository has been archived by the owner. It is now read-only.

cranelift-wasm: Jump to the destination block at end of consequent #1110

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Oct 2, 2019

This commit fixes a bug where at the end of an if..else..end's consequent block, we would sometimes erroneously jump to the else block instead of to the following destination block. Not good!

This commit fixes a bug where at the end of an `if..else..end`'s consequent
block, we would sometimes erroneously jump to the `else` block instead of to the
following destination block. Not good!
@fitzgen
Copy link
Member Author

fitzgen commented Oct 3, 2019

(Note: this was introduced by my multi-value PR, and is only possible to hit this bug with multi-value enabled)

@sunfishcode
Copy link
Member

sunfishcode commented Oct 3, 2019

Thanks!

@sunfishcode sunfishcode merged commit ee6fe21 into bytecodealliance:master Oct 3, 2019
@fitzgen
Copy link
Member Author

fitzgen commented Oct 3, 2019

Thank you!

@fitzgen fitzgen deleted the wasm-multivalue-if-else-block-mixup branch Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants