Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift-wasm: Jump to the destination block at end of consequent #1110

Conversation

@fitzgen
Copy link
Member

fitzgen commented Oct 2, 2019

This commit fixes a bug where at the end of an if..else..end's consequent block, we would sometimes erroneously jump to the else block instead of to the following destination block. Not good!

This commit fixes a bug where at the end of an `if..else..end`'s consequent
block, we would sometimes erroneously jump to the `else` block instead of to the
following destination block. Not good!
@fitzgen

This comment has been minimized.

Copy link
Member Author

fitzgen commented Oct 3, 2019

(Note: this was introduced by my multi-value PR, and is only possible to hit this bug with multi-value enabled)

@sunfishcode

This comment has been minimized.

Copy link
Member

sunfishcode commented Oct 3, 2019

Thanks!

@sunfishcode sunfishcode merged commit ee6fe21 into bytecodealliance:master Oct 3, 2019
13 checks passed
13 checks passed
CraneStation.cranelift Build #refs_pull_1110_merge-2019-10-02.1 succeeded
Details
CraneStation.cranelift (Build mac) Build mac succeeded
Details
CraneStation.cranelift (Build windows) Build windows succeeded
Details
CraneStation.cranelift (Build_linux) Build_linux succeeded
Details
CraneStation.cranelift (Fuzz regression) Fuzz regression succeeded
Details
CraneStation.cranelift (Test linux-earliest) Test linux-earliest succeeded
Details
CraneStation.cranelift (Test mac-beta) Test mac-beta succeeded
Details
CraneStation.cranelift (Test mac-earliest) Test mac-earliest succeeded
Details
CraneStation.cranelift (Test mac-nightly) Test mac-nightly succeeded
Details
CraneStation.cranelift (Test mac-stable) Test mac-stable succeeded
Details
CraneStation.cranelift (Test windows-earliest) Test windows-earliest succeeded
Details
CraneStation.cranelift (docs) docs succeeded
Details
CraneStation.cranelift (rustfmt) rustfmt succeeded
Details
@fitzgen

This comment has been minimized.

Copy link
Member Author

fitzgen commented Oct 3, 2019

Thank you!

@fitzgen fitzgen deleted the fitzgen:wasm-multivalue-if-else-block-mixup branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.