Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit rex for brz and brnz encodings #1308

Merged
merged 1 commit into from Dec 22, 2019

Conversation

@bjorn3
Copy link
Contributor

bjorn3 commented Dec 21, 2019

  • A short description of what this does, why it is needed; if the
    description becomes long, the matter should probably be discussed in an issue
    first. See title
  • This PR contains test cases, if meaningful.
  • A reviewer from the core maintainer team has been assigned for this PR.
    If you don't know who could review this, please indicate so and/or ping
    bnjbvr. The list of suggested reviewers on the right can help you.

Fixes #1305

Fixes #1305
@bjorn3

This comment has been minimized.

Copy link
Contributor Author

bjorn3 commented Dec 21, 2019

Using .rex().w() instead of .infer_rex().w() in enc_i32_i64 also fixed the problem.

Copy link
Collaborator

sstangl left a comment

Thanks. The most likely culprit is that the branch-target logic doesn't use the compute_size() function correctly when considering its own instruction size, something to that effect. We'll have to fix it for real, but it's better to not crash in the meantime.

@sstangl sstangl merged commit 722a345 into bytecodealliance:master Dec 22, 2019
3 of 12 checks passed
3 of 12 checks passed
Rustfmt
Details
Build API Docs
Details
Test (windows-earliest) Test (windows-earliest)
Details
Test (linux-earliest) Test (linux-earliest)
Details
Test (mac-earliest) Test (mac-earliest)
Details
Test (stable) Test (stable)
Details
Test (beta) Test (beta)
Details
Test (nightly) Test (nightly)
Details
Test (windows-release) Test (windows-release)
Details
Test (linux-release) Test (linux-release)
Details
Test (mac-release) Test (mac-release)
Details
Meta deterministic check
Details
@bjorn3 bjorn3 deleted the bjorn3:x86_fix_rex_for_brz_brnz branch Dec 22, 2019
@bnjbvr bnjbvr mentioned this pull request Jan 6, 2020
@bjorn3 bjorn3 mentioned this pull request Jan 6, 2020
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.