This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Remove no-longer-needed helper method#182
Merged
alexcrichton merged 1 commit intoJun 3, 2025
Merged
Conversation
In trying to upstream this helper method it had surprising semantics for insert-beyond-the-end and so upon investigating I concluded that this may be a historical artifact at this point and no longer needed. To reduce the diff with upstream this commit removes the method and replaces the one usage with a locally-equivalent structure.
dicej
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to upstream this helper method it had surprising semantics for insert-beyond-the-end and so upon investigating I concluded that this may be a historical artifact at this point and no longer needed. To reduce the diff with upstream this commit removes the method and replaces the one usage with a locally-equivalent structure.