Update to new GC cast instruction encoding #1127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per WebAssembly/gc#359 (comment), the encoding for GC cast instructions has changed to use two separate opcodes for
br_on_cast
andbr_on_cast_fail
, rather than being disambiguated by a flag bit.I looked around for other places to update, but it seems like parsing isn't implemented for GC instructions yet? Roundtrip tests are also crashing on my local computer on the latest main, so I'm unable to properly test this. Would appreciate any guidance.