Conversation
|
(Note: this just enables function calls with multiple return values, it doesn't attempt to handle multi-value blocks yet, which I figure can come in follow up PRs). |
|
Added support for multi-value blocks, which was slightly more involved since it had to mess with control frames / |
|
It looks good. The only question have is where I can find a spec for the encoding used in the patch? There is https://webassembly.github.io/multi-value/core/binary/types.html#function-types, but it does not match the logic at the |
|
See https://webassembly.github.io/multi-value/core/binary/instructions.html#binary-blocktype and the paragraph just above it:
|
yurydelendik
left a comment
There was a problem hiding this comment.
Looks good with the minor changes
|
Pushed a new commit with feedback addressed. |
|
Thank you for the patch. |
|
Thanks! |
Builds on top of #102