Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow `[t*] -> [t*]` if blocks with no else #135
Merged
Conversation
yurydelendik
merged commit 70000a6
into
bytecodealliance:master
1 check was pending
1 check was pending
This comment has been minimized.
This comment has been minimized.
|
Thank you for the patch. |
This was referenced Oct 3, 2019
fitzgen
referenced
this pull request
in fitzgen/wasmtime
Oct 3, 2019
This has a bug fix for multi-value Wasm validation that is required for getting the spec tests passing. https://github.com/yurydelendik/wasmparser.rs/pull/135
fitzgen
referenced
this pull request
in fitzgen/wasmtime
Oct 15, 2019
This has a bug fix for multi-value Wasm validation that is required for getting the spec tests passing. https://github.com/yurydelendik/wasmparser.rs/pull/135
fitzgen
referenced
this pull request
in fitzgen/wasmtime
Oct 17, 2019
This has a bug fix for multi-value Wasm validation that is required for getting the spec tests passing. https://github.com/yurydelendik/wasmparser.rs/pull/135
sunfishcode
referenced
this pull request
in bytecodealliance/wasmtime
Oct 18, 2019
* deps: bump wasmparser to 0.39.2 This has a bug fix for multi-value Wasm validation that is required for getting the spec tests passing. https://github.com/yurydelendik/wasmparser.rs/pull/135 * Update cranelift to 0.46.1 to get multi-value Wasm support The `cranelift_wasm` APIs had to change a little bit to maintain state necessary when translating multi-value Wasm blocks. The `translate_module` function now returns a `ModuleTranslationState` that is borrowed during each function's translation. * Enable multi-value proposal's spec tests This enables all the Wasm multi-value proposal's spec tests other than the ones that rely on functions having more return values than registers available on the target. That is not supported by cranelift yet. * wasmtime-interface-types: always use multi-value Wasm And remove the return pointer hacks that work around the lack of multi-value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedSep 26, 2019
As long as the start and end types are the same, then we don't need to require an
elseblock because a no-op will trivially implements that type signature.This also enables the multi-value proposal spec tests, which test for this.