Repository navigation
Exceptions: handle try_table in unreachable code properly. - #11507
Merged
alexcrichton merged 1 commit intoAug 22, 2025
Merged
Conversation
Our Wasm-to-CLIF translator has a separate match-over-opcodes for unreachable code that mostly does nothing, but needs to push entries onto the control stack so that `end`-opcode processing works properly and tracks the bytecode's nesting (which is important because after an `end` we might re-enter reachable code). Previously, `try_table` was not handled here -- it fell into the catchall case that did nothing -- so a `try_table` in unreachable code (most trivially, `(unreachable) (try_table)` in any block) would result in a panic. This PR fixes that by updating `try_table` handling to work like `block` and `loop` in unreachable contexts. Fixes bytecodealliance#11505.
alexcrichton
approved these changes
Aug 22, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
…ealliance#11507) Our Wasm-to-CLIF translator has a separate match-over-opcodes for unreachable code that mostly does nothing, but needs to push entries onto the control stack so that `end`-opcode processing works properly and tracks the bytecode's nesting (which is important because after an `end` we might re-enter reachable code). Previously, `try_table` was not handled here -- it fell into the catchall case that did nothing -- so a `try_table` in unreachable code (most trivially, `(unreachable) (try_table)` in any block) would result in a panic. This PR fixes that by updating `try_table` handling to work like `block` and `loop` in unreachable contexts. Fixes bytecodealliance#11505.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Wasm-to-CLIF translator has a separate match-over-opcodes for unreachable code that mostly does nothing, but needs to push entries onto the control stack so that
end-opcode processing works properly and tracks the bytecode's nesting (which is important because after anendwe might re-enter reachable code).Previously,
try_tablewas not handled here -- it fell into the catchall case that did nothing -- so atry_tablein unreachable code (most trivially,(unreachable) (try_table)in any block) would result in a panic. This PR fixes that by updatingtry_tablehandling to work likeblockandloopin unreachable contexts.Fixes #11505.