From d1ac513d00b0cd3e2a869544c2bc067b5f6298b3 Mon Sep 17 00:00:00 2001 From: Masahiro Kozuka Date: Tue, 9 Sep 2025 00:42:59 +0000 Subject: [PATCH 1/3] fix memory leak --- crates/wasi-nn/src/wit.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/wasi-nn/src/wit.rs b/crates/wasi-nn/src/wit.rs index a5cd9812bfa4..0d276f68f805 100644 --- a/crates/wasi-nn/src/wit.rs +++ b/crates/wasi-nn/src/wit.rs @@ -249,11 +249,11 @@ impl generated::inference::HostGraphExecutionContext for WasiNnView<'_> { tracing::debug!("compute with {} inputs", inputs.len()); let mut named_tensors = Vec::new(); - for (name, tensor_resopurce) in inputs.iter() { - let tensor = self.table.get(&tensor_resopurce)?; + for (name, tensor_resopurce) in inputs.into_iter() { + let tensor = self.table.delete(tensor_resopurce)?; named_tensors.push(crate::backend::NamedTensor { - name: name.clone(), - tensor: tensor.clone(), + name: name, + tensor: tensor, }); } From b4e10c3ba308cef2522c940dda19d47cf834e8d3 Mon Sep 17 00:00:00 2001 From: Masahiro Kozuka Date: Wed, 17 Sep 2025 07:23:34 +0000 Subject: [PATCH 2/3] fix clippy::redundant_field_names --- crates/wasi-nn/src/wit.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/wasi-nn/src/wit.rs b/crates/wasi-nn/src/wit.rs index 0d276f68f805..723917dbd468 100644 --- a/crates/wasi-nn/src/wit.rs +++ b/crates/wasi-nn/src/wit.rs @@ -252,8 +252,8 @@ impl generated::inference::HostGraphExecutionContext for WasiNnView<'_> { for (name, tensor_resopurce) in inputs.into_iter() { let tensor = self.table.delete(tensor_resopurce)?; named_tensors.push(crate::backend::NamedTensor { - name: name, - tensor: tensor, + name, + tensor, }); } From 577ae876bbe5fa3f36f0767cf434f0c7fea009f7 Mon Sep 17 00:00:00 2001 From: Masahiro Kozuka Date: Wed, 17 Sep 2025 07:25:26 +0000 Subject: [PATCH 3/3] fix format --- crates/wasi-nn/src/wit.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/crates/wasi-nn/src/wit.rs b/crates/wasi-nn/src/wit.rs index 723917dbd468..48703e3eb492 100644 --- a/crates/wasi-nn/src/wit.rs +++ b/crates/wasi-nn/src/wit.rs @@ -251,10 +251,7 @@ impl generated::inference::HostGraphExecutionContext for WasiNnView<'_> { let mut named_tensors = Vec::new(); for (name, tensor_resopurce) in inputs.into_iter() { let tensor = self.table.delete(tensor_resopurce)?; - named_tensors.push(crate::backend::NamedTensor { - name, - tensor, - }); + named_tensors.push(crate::backend::NamedTensor { name, tensor }); } let exec_context = &mut self.table.get_mut(&exec_context)?;