Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #4332 to 0.38 branch. #4336



Copy link

@cfallin cfallin commented Jun 27, 2022

This is a cherry-pick of the fix in #4332, which we want to ride along with our other register allocator-related fix in the point release in order to fully address the reported issues from cg_clif.

@cfallin cfallin requested a review from alexcrichton Jun 27, 2022
@cfallin cfallin changed the base branch from main to release-0.38.0 Jun 27, 2022
Copy link

alexcrichton commented Jun 27, 2022

@cfallin if you want to rebase this one I think it should be good to merge

cfallin added 2 commits Jun 27, 2022

`idiv` on x86-64 only reads `rdx`/`edx`/`dx`/`dl` for divides with width
greater than 8 bits; for an 8-bit divide, it reads the whole 16-bit
divisor from `ax`, as our CISC ancestors intended. This PR fixes the
metadata to avoid a regalloc panic (due to undefined `rdx`) in this
case. Does not affect Wasmtime or other Wasm-frontend embedders.
Copy link
Member Author

cfallin commented Jun 27, 2022

Rebased, will merge once tests are green.

Copy link

alexcrichton commented Jun 27, 2022

Given the green status on #4332 and the prior green status on #4333 for the release-0.38.0 branch I'm actually gonna go ahead and merge this to help reduce our CI load a bit (which is a bit overloaded at the moment...).

I'll wait for the full green sign off on #4339 which I will subsequently rebase over this and put the final touches on the release notes there (mostly the simd fixes)

@alexcrichton alexcrichton merged commit 94fd5b0 into bytecodealliance:release-0.38.0 Jun 27, 2022
0 of 23 checks passed
@cfallin cfallin deleted the update-0.38.0-idiv8 branch Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants