Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.38.0] Backport CI fixes #4491

Merged

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jul 20, 2022

This includes an s390x-specific fix for constants but an additional all-platforms fix for the reftyped_vregs array.

This commit fixes an issue introduced as part of the fix for
GHSA-5fhj-g3p3-pq9g. The `reftyped_vregs` list given to `regalloc2` is
not allowed to have duplicates in it and while the list originally
doesn't have duplicates once aliases are applied the list may have
duplicates. The fix here is to perform another pass to remove duplicates
after the aliases have been processed.
This carries over a narrow fix from bytecodealliance#4427 to prior release branches. The
patch here was created by `@uweigand` during the investigation for bytecodealliance#4487.
@alexcrichton alexcrichton requested a review from cfallin Jul 20, 2022
@alexcrichton
Copy link
Member Author

alexcrichton commented Jul 20, 2022

cc @uweigand for this as well (same as #4490 just a different base branch)

@uweigand
Copy link
Member

uweigand commented Jul 20, 2022

cc @uweigand for this as well (same as #4490 just a different base branch)

LGTM as well. Thanks!

@alexcrichton alexcrichton merged commit 3969e02 into bytecodealliance:release-0.38.0 Jul 20, 2022
23 checks passed
@alexcrichton alexcrichton deleted the release-0.38.0 branch Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants