Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a 2.0.1 release of Wasmtime #5136



Copy link

This PR backports a number of CI fixes related to the automatic production of artifacts and additionally notably backports #5134 for the true "meat" of the 2.0.1 release. I've slated this for publication tomorrow and will cycle CI to do the bump after this lands for merging of the bump tomorrow to give CI a chance to settle.

alexcrichton and others added 6 commits October 26, 2022 12:24
This commit fixes the `push-tag.yml` workflow to work with the new
`Cargo.toml` manifest since workspace inheritance was added. This
additionally fixes some warnings coming up on CI about our usage of
deprecated features on github actions.
* Upgrade our github actions to "node16"

Each github actions run has a lot of warnings about using node12 so this
upgrades our repository to using node16. I'm hoping no other changes are
needed and I suspect other actions we're using are on node12 and will
need further updates, but this should help pin down what's remaining.

* Update `actions/checkout` workflow to `v3`

* Update to `actions/cache@v3`

* Update to `actions/upload-artifact@v3`

* Drop usage of `actions-rs/toolchain`

* Update to `actions/setup-python@v4`

* Update mdbook version

A local github action we have has been broken for about a month now
meaning that the `dev` tag isn't getting updated or getting new
releases. This appears to be due to the publication of new versions of
these dependencies which are running into issues using one another. I
think I've figured out versions that work and have added a
`package-lock.json` to ensure we keep using the same versions.
Looks like bytecodealliance#5091 wasn't enough and some of the APIs needed updating with
changes made in the meantime. I've updated the action here and
additionally made a separate change where the release isn't continually
created and deleted but instead left alone and only the tag is updated.
This should work for the `dev` release and avoids deleting/recreating on
each PR, sending out notifications for new releases.
This is necessary for the `wasmtime-runtime` crate to compile on Windows.
Copy link

What do you think of backporting #5101 as well? It fixes a regression in how long Cranelift takes to build.

bjorn3 and others added 2 commits October 26, 2022 12:47
Using rayon adds a lot of dependencies to Cranelift. The total
unparallelized time the code that uses rayon takes is less than half a
second and it runs at compile time, so there is pretty much no benefit
to parallelizing it.
Copy link
Member Author

Sounds reasonable to me 👍

@alexcrichton alexcrichton merged commit 2ebb8a5 into bytecodealliance:release-2.0.0 Oct 26, 2022
@alexcrichton alexcrichton deleted the backports-for-2.0.1 branch October 26, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants