Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the two factor controller #1

Conversation

@leofeyer
Copy link

leofeyer commented Jan 8, 2020

These are my suggested changes for contao#719.

  1. Throw an InsufficientAuthenticationException exception if the user is not fully authenticated.
  2. Move the security check into the __invoke() method.
  3. Use the security helper instead of the token storage to retrieve the user.
  4. Adjust the tests.
@leofeyer leofeyer mentioned this pull request Jan 8, 2020
2 of 2 tasks complete
@bytehead bytehead merged commit b4ad6ef into bytehead:feature/2fa-backup-codes Jan 8, 2020
8 checks passed
8 checks passed
Coverage
Details
Coding Style
Details
PHP 7.2
Details
PHP 7.3
Details
PHP 7.4
Details
Prefer Lowest
Details
Bundles
Details
Windows
Details
@bytehead bytehead deleted the contao:feature/2fa-backup-codes-changes branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.