New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYTEMAN-190 Support automation of offline parsing and typechecking #19

Merged
merged 1 commit into from Jun 13, 2013

Conversation

Projects
None yet
3 participants
@zhfeng
Contributor

zhfeng commented Jun 6, 2013

No description provided.

@paulrobinson

This comment has been minimized.

Show comment
Hide comment
@paulrobinson

paulrobinson Jun 8, 2013

I wonder if it is possible to do an exhaustive search over the code base looking for un-checked byteman scripts? This is likely to be an expensive opertaion, so would be disabled by default.

Maybe this is not a good idea, it would depend on how easy it is to detect these scripts and how intensive it is on a large code-base.

WDYT?

paulrobinson commented Jun 8, 2013

I wonder if it is possible to do an exhaustive search over the code base looking for un-checked byteman scripts? This is likely to be an expensive opertaion, so would be disabled by default.

Maybe this is not a good idea, it would depend on how easy it is to detect these scripts and how intensive it is on a large code-base.

WDYT?

@paulrobinson

This comment has been minimized.

Show comment
Hide comment
@paulrobinson

paulrobinson Jun 8, 2013

Would it make sense to include .btm and .txt files by default and only deviate if a different 'includes' element is provided in the plugin?

Would this be simpler for the user, or confusing?

WDYT?

paulrobinson commented Jun 8, 2013

Would it make sense to include .btm and .txt files by default and only deviate if a different 'includes' element is provided in the plugin?

Would this be simpler for the user, or confusing?

WDYT?

* Location of the script.
*/
@Parameter( defaultValue = "${project.build.testOutputDirectory}", property = "scriptDir", required = true )
private File scriptDir;

This comment has been minimized.

@zhfeng

zhfeng Jun 9, 2013

Contributor

we can set defaultValue of scriptDir to "${project.build}" but it looks like the duplicate scripts could be included, e.g "src/test/resources" and "target/test-classes"

@zhfeng

zhfeng Jun 9, 2013

Contributor

we can set defaultValue of scriptDir to "${project.build}" but it looks like the duplicate scripts could be included, e.g "src/test/resources" and "target/test-classes"

adinn added a commit that referenced this pull request Jun 13, 2013

Merge pull request #19 from zhfeng/BYTEMAN-190
BYTEMAN-190 Support automation of offline parsing and typechecking

@adinn adinn merged commit c88acb8 into bytemanproject:master Jun 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment