Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[byu-menu] Max width only contains the menu #379

Closed
4 of 19 tasks
blakemorgan opened this issue Oct 9, 2018 · 0 comments
Closed
4 of 19 tasks

[byu-menu] Max width only contains the menu #379

blakemorgan opened this issue Oct 9, 2018 · 0 comments
Assignees
@blakemorgan
Labels
documentation
Milestone
1.3.5

Comments

@blakemorgan
Copy link
Contributor

blakemorgan commented Oct 9, 2018 •
edited by arzon94

Description

The documentation makes it sound like the max-width attribute will constrain the header and footer, but it only constrains the menu.

screenshot from 2018-10-09 11-44-41

Websites Affected

http://asb-ucom-web3-l.byu.edu

Issue Type

Is this (add an x in the boxes that apply)

  • A difference between the components and the Official Specification?
  • A bug, such as a Javascript error, or the UI not rendering properly
    on a page?
  • Inconsistent appearance/behavior between browsers?
  • An issue on mobile browsers?
  • A request for a new feature/enhancement?

Browsers Affected

Add an x in all the boxes that apply. Please mark desktop and mobile
browsers separately.

We support the last two versions of Chrome, Firefox, Safari, and Edge.

Desktop Browsers

  • Google Chrome
  • Mozilla Firefox
  • Apple Safari
  • Microsoft Edge
  • Other (please specify)

Mobile Browsers

  • Any browser on iOS
  • Chrome for Android
  • Firefox Mobile for Android
  • Other (please specify)

Web Site Platform

What is hosting your website?

  • Drupal 7
  • Drupal 8
  • Wordpress
  • Custom Site
  • Don't Know
@blakemorgan blakemorgan changed the title Max width only contains the menu [byu-menu] Max width only contains the menu Oct 29, 2018
@blakemorgan blakemorgan self-assigned this Nov 12, 2018
@blakemorgan blakemorgan added this to the 1.3.5 milestone Nov 13, 2018
blakemorgan added a commit that referenced this issue Nov 20, 2018
@blakemorgan
Fixes #379
60cfa24
@blakemorgan blakemorgan mentioned this issue Nov 20, 2018
Merged
9 tasks
blakemorgan added a commit that referenced this issue Nov 26, 2018
@blakemorgan
Fixes Issue #430 (#431)
6084760 
* Move and adjust z-index

* Run build.

* Fixes #379 (#426)

* added documentation for double-wide footer in tablet view (#429)

* Fixes #382 (#427)

* Add custom placeholder attribute.

* Run build

* gulpfile update and added placeholder demo

* Update fallback fonts. Fixes #419 (#428)

* running build

* merging from master

* Move and adjust z-index

* Run build.

* Run build
@blakemorgan blakemorgan mentioned this issue Nov 26, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakemorgan blakemorgan

Labels
documentation
Projects
None yet
Milestone
1.3.5
Development

No branches or pull requests
1 participant
@blakemorgan