Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 hotfix #457

Merged
merged 16 commits into from Jul 30, 2019

Conversation

@blakemorgan
Copy link
Member

commented Jul 30, 2019

Summary of Changes

This fix puts styles in :host so they don't override page styles. Now that styles and in :host, I was able to remove the global box-sizing and position that was messing up people's sites.

Browser Testing

I have tested these changes in:

Add an x in all the boxes that apply. Please mark desktop and mobile
browsers separately.

Desktop Browsers

  • Google Chrome
  • Mozilla Firefox
  • Apple Safari
  • Microsoft Edge
  • Other (please specify)

Mobile Browsers

  • Any browser on iOS
  • Chrome for Android
  • Firefox Mobile for Android
  • Other (please specify)

We support the last two versions of Chrome, Firefox, Safari, and Edge.

blakemorgan added 9 commits Jul 30, 2019
@blakemorgan blakemorgan requested a review from kebowdog Jul 30, 2019
Copy link
Contributor

left a comment

LGTM

@blakemorgan blakemorgan merged commit d2765be into master Jul 30, 2019
@blakemorgan blakemorgan deleted the 201-hotfix branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.