Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing #4

Open
ninjatrench opened this issue Jul 13, 2016 · 4 comments
Open

Automated testing #4

ninjatrench opened this issue Jul 13, 2016 · 4 comments

Comments

@ninjatrench
Copy link

Pre-run Tests :

  • Verify Config files exists
  • Setup SQLite if not postgresql
  • Python dependency Check

Unittesting :

  • SQLite support
  • SetupDB
  • Add a short URL
@bzed
Copy link
Owner

bzed commented Jul 14, 2016

  • check that the short url is correct
  • create a longish list of weird urls and check them

ninjatrench pushed a commit to ninjatrench/go.debian.net that referenced this issue Jul 30, 2016
bzed#4 sqlite supported
removed nextval() dependency
@ninjatrench
Copy link
Author

Share lock thing also not supported in SQLlite so commented out that part and replaced

 id = session.execute("""select nextval('%s');""" % (_URL_ID_SEQ,)).fetchone()[0]

with in godebian/db.py line 174-175

id = int(session.query(Url.pk).count()) + 1

@ninjatrench
Copy link
Author

ninjatrench commented Jul 30, 2016

Done :

  • Basic tests : added but needs some proper testing sequence and implement unittesting
  • SetupDB : added
  • Setup SQLite if not postgresql : added by making SQLlite as default config attribute
  • Verify Config files exist : done also added default config if config files are missing.
  • Added bool switch in config.py for production and development mode separate configuration

Pending :

  • Python dependency Check
  • Unittesting
  • Travis-ci build

ninjatrench pushed a commit to ninjatrench/go.debian.net that referenced this issue Aug 4, 2016
bzed#3 test cases for percent-encoded characters in URL
ninjatrench pushed a commit to ninjatrench/go.debian.net that referenced this issue Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants