Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb.li is mangling some percent-encoded characters #5

Open
bzed opened this issue Jul 14, 2016 · 3 comments
Open

deb.li is mangling some percent-encoded characters #5

bzed opened this issue Jul 14, 2016 · 3 comments

Comments

@bzed
Copy link
Owner

bzed commented Jul 14, 2016

deb.li is mangling some percent-encoded characters. For example:

jwilk@moszumanska:~$ ~bzed/godebian-client/add_url 'http://www.example.com/?q=foo%2Bbar'
xekG
jwilk@moszumanska:~$ curl -s --include 'http://deb.li/xekG' | grep -m1 ^Location
Location: http://www.example.com/?q=foo+bar

Note that %2B has been replaced with + in the query string, but these are entirely different things: the former denotes the plus character, while the latter denotes the space character.

@ninjatrench
Copy link

Hi,
as per this list http://www.w3schools.com/tags/ref_urlencode.asp
the "%2B" denotes "+" sign which is what your code actually did, I don't see how that is wrong

@bzed
Copy link
Owner Author

bzed commented Jul 14, 2016

https://en.wikipedia.org/wiki/Query_string#Indexed_search has the gory details ....

@bzed
Copy link
Owner Author

bzed commented Jul 14, 2016

Also please note this single sentence on the w3schools url you've referenced:
URL encoding normally replaces a space with a plus (+) sign or with %20.

ninjatrench pushed a commit to ninjatrench/go.debian.net that referenced this issue Jul 30, 2016
bzed#4 sqlite supported
removed nextval() dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants