Fix report duplicates #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
It does not change how the aggregation works (exact match of title, url, abstract) but rather fixes the cause of duplication in that particular case: scholar -> paper URL extraction not handling different TLDs. Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
bzz
force-pushed
the
fix-report-duplicates
branch
from
0038712
to
2ae3d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12 by more careful URL extraction.
It does not change how the aggregation works (exact match of title, url, abstract) but rather adds a simpler fix for the cause of duplication in that particular case: a scholar -> paper URL extraction was not handling different TLDs.
Now it does, and TODO is added for a possibly different aggregation that is going to be taken care of under a separate PR later.