Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1: Create directories and pyproject.toml #2

Merged
merged 9 commits into from
Oct 4, 2022
Merged

Issue #1: Create directories and pyproject.toml #2

merged 9 commits into from
Oct 4, 2022

Conversation

lisphilar
Copy link
Contributor

@lisphilar lisphilar commented Oct 4, 2022 •
edited
Loading

Related issues

#1

What was changed

  • As described in Create directories and pyproject.toml #1, directories for dim library and tests (with pytest) was created.
  • Add pyproject.toml and poetry.lock to develop the library with poetry
  • Add dim.__version__
  • Add .gitignore for Python
  • Document installation guide on README
  • Add test workflow with Poetry and CodeQL

@lisphilar lisphilar added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2022
@lisphilar lisphilar requested a review from ryo-ma October 4, 2022 11:35
@ryo-ma
Copy link
Contributor

ryo-ma commented Oct 4, 2022

LGTM

@ryo-ma ryo-ma linked an issue Oct 4, 2022 that may be closed by this pull request
Create directories and pyproject.toml #1
Closed
@ryo-ma ryo-ma merged commit 0e357df into main Oct 4, 2022
@lisphilar lisphilar deleted the issue1 branch October 5, 2022 10:24
@lisphilar lisphilar mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryo-ma ryo-ma ryo-ma approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create directories and pyproject.toml
2 participants
@lisphilar @ryo-ma