Skip to content

FILEVERSIONINFO is set for cares.dll on Windows builds #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BadBoyBadders opened this issue Apr 7, 2022 · 1 comment
Closed

FILEVERSIONINFO is set for cares.dll on Windows builds #460

BadBoyBadders opened this issue Apr 7, 2022 · 1 comment

Comments

@BadBoyBadders
Copy link

For release we are looking to distribute cares.dll and on building using CMake on Windows we have noticed that cares.dll does not have the version information defined.

There appears to be a cares.rc file in the src/lib folder which contains the StringFileInfo block to set the dll file information (including version), but this is not included in the src/lib/Makefile.inc CSOURCES defintion. Adding the resource file to this list does build cares.dll with file information on Windows.

Is this deliberately left out due to platform/architecture build issues, been superceeded, or can this be added?

Many thanks.
bradh352 added a commit that referenced this issue Apr 27, 2022
@bradh352
CMake: Windows DLLs lack version information
e01dbc6 
The cares.rc was not included in the build for CMake.  Conditionally
add it when building for Windows.

Fix By: Brad House (@bradh352)
Fixes Bug: #460
@bradh352
Copy link
Member

should be fixed in e01dbc6

can not add to Makefile.inc due to it not having the ability to conditionally include on only certain systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradh352 @BadBoyBadders