Make gethostbyaddr fail with ECANCELLED for ares_cancel()#138
Closed
addaleax wants to merge 1 commit intoc-ares:masterfrom
Closed
Make gethostbyaddr fail with ECANCELLED for ares_cancel()#138addaleax wants to merge 1 commit intoc-ares:masterfrom
ECANCELLED for ares_cancel()#138addaleax wants to merge 1 commit intoc-ares:masterfrom
Conversation
When `ares_cancel()` was invoked, `ares_gethostbyaddr()` queries would fail with `ENOTFOUND` instead of `ECANCELLED`. It seems appropriate to treat `ares_cancel()` like `ares_destroy()`, but I would appreciate review of the correctness of this change. Ref: nodejs/node#14814
Contributor
|
If this is correct, then presumably |
Contributor
Author
|
@dimbleby I don’t think so, for |
tniessen
approved these changes
Aug 15, 2017
Contributor
Author
|
Bump, anything I can do for this to be merged? Should I ping the mailing list? |
Member
|
Thanks! |
DronRathore
pushed a commit
to DronRathore/c-ares
that referenced
this pull request
Mar 11, 2020
When `ares_cancel()` was invoked, `ares_gethostbyaddr()` queries would fail with `ENOTFOUND` instead of `ECANCELLED`. It seems appropriate to treat `ares_cancel()` like `ares_destroy()`, but I would appreciate review of the correctness of this change. Ref: nodejs/node#14814 Closes c-ares#138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ares_cancel()was invoked,ares_gethostbyaddr()queries would fail withENOTFOUNDinstead ofECANCELLED.It seems appropriate to treat
ares_cancel()likeares_destroy(), but I would appreciate review of the correctness of this change.Ref: nodejs/node#14814