Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing name servers while queries are outstanding #191

Merged
merged 1 commit into from May 17, 2018

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented May 15, 2018

It doesn't work, per #41. Probably it simply isn't intended usage. Better to return an error code than to crash.

ARES_ENOTIMP seems the most appropriate of the existing error codes. I did consider introducing a new one just for this, but it seemed a bit much. Happy to be change if you think otherwise.

It doesn't work, per #41.  Better to return an error code than to crash.
@bradh352 bradh352 self-requested a review May 17, 2018
@bradh352 bradh352 merged commit 078e1dc into c-ares:master May 17, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dimbleby dimbleby deleted the dimbleby:prevent-bad-set-servers branch May 17, 2018
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Oct 22, 2018
Original commit message:

    Prevent changing name servers while queries are outstanding

    Changing name servers doesn't work, per c-ares/c-ares#41.
    Better to return an error code than to crash.

Refs: c-ares/c-ares#41
Refs: c-ares/c-ares#191
Refs: nodejs#894
DronRathore added a commit to DronRathore/c-ares that referenced this pull request Mar 11, 2020
Changing name servers doesn't work, per c-ares#41.  Better to return an error code than to crash.

Fix-by: David Hotham @dimbleby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants